Handle legacy NBT warning on data component versions - #306
Open
pneqnp-iswr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Minecraft versions using item data components, the legacy NBT hook is no longer applicable.
DeluxeMenus currently reports this as a warning:
Could not setup a NMS hook for your server version!However, on data component versions this is expected behavior rather than a hook failure.
This change detects
VersionHelper.HAS_DATA_COMPONENTSbefore checking the legacy NBT provider and reports the unsupported legacy NBT item options as an informational message instead.This does not attempt to restore the legacy
nbt_int,nbt_ints,nbt_string, ornbt_stringsoptions on modern versions.Related to #196.
This is separate from #290, which addresses CraftBukkit package resolution on Paper 26.x.