eCLM-ParFlow: Calculate hydraulic conductivity based on ParFlow's water content - #129
Draft
s-poll wants to merge 5 commits into
Draft
eCLM-ParFlow: Calculate hydraulic conductivity based on ParFlow's water content#129s-poll wants to merge 5 commits into
s-poll wants to merge 5 commits into
Conversation
avoid spamming in log file, thereby improve performance
- ParFlow has no ice phase, thus pfl_h2osoi_liq is the total soil water. Cap the diagnosed ice content and take the remaining as liquid.
…er content - bugfix: before hk_l was never set for soil water movement method 4, value was the initial value =0 all time - recompute hk_l from ParFlow water content similar to standalone eCLM - see details in #128
- icefrac was last set in infiltration, so the ice impedance in hk_l used a stale value - refresh icefrac from the capped h2osoi_ice, as in Infiltration
This reverts commit b9d7307.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In ParFlow-coupled simulations (
soilwater_movement_method = 4,-DCOUP_OAS_PFL) the soil hydraulic conductivityhk_l_colstays at its cold-start value of0._r8for the whole run, and is written as zero into the restart file.Because the soil-to-root conductance in the plant-hydraulic-stress scheme is derived from
hk_la zero
hk_lmakes the soil-to-root pathway infinitely resistive: roots cannot extract water, canopy transpiration collapses to almost zero over the whole domain and latent heat flux is strongly underestimated.hk_lis also used by the VIC-type drainage weighting inDrainage/LateralFlowPowerLawand is theHKhistory field, so both are meaningless in coupled runs.Root Cause
hk_l_colis only ever assigned insoilwater_zengdecker2009and incompute_hydraulic_properties(called fromsoilwater_moisture_form), not in a coupled simulation:soilwater_parflow.Solution
Recompute hk_l inside soilwater_parflow from the ParFlow water content using the same formulation as in the standalone model (compute_hydraulic_properties), so that the definitions of hydraulic conductivity in the coupled and standalone runs are the same.
In addition, ice fraction is refreshed from the capped h₂osoi_ice before the impedance is evaluated.
ice_fracis last set in 'Infiltration', i.e. before the ice limiter that 'soilwater_parflow' applies when partitioning the ParFlow total water. This means that the impedance would otherwise be based on an outdated ice fraction.Scope of the change:
soilwater_parflowis touchedsmp_lhandling is unchanged (still taken from the ParFlow pressure head).Related Issues
hk_lis never computed resulting in suppressed transpiration #128