Conversation
…ntours rather than tracing at a given z and then stepping down
Contributor
|
using |
Author
jeffc
marked this pull request as draft
September 10, 2026 00:49
Author
|
Converting to a draft; this doesn't respect tabs like I thought (it did at one point, but I must have broken it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds a "continuous" mode to the trace op, which interpolates the z step down over the perimeter of the path rather than tracing the whole path then plunging straight down:
I wrote it to only have an effect on closed paths, since open paths would still end up with a plunge if we applied the same logic (unless we "zig-zag" back and forth along the open path, which means alternating climb and conventional milling). If you think this should work for open paths too, let me know and I'll update the PR.