docs: Update nightly WAL documentation for bounded Kafka requests#2837
Conversation
Co-authored-by: WenyXu <32535939+WenyXu@users.noreply.github.com>
Deploying greptime-docs with
|
| Latest commit: |
7ab2558
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://06bd301c.greptime-docs.pages.dev |
| Branch Preview URL: | https://copilot-update-nightly-zh-an.greptime-docs.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
The updated timeout wording does not yet explicitly clarify that the deadline covers the full Kafka request lifecycle (send + response wait), which is the key semantic change being documented.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates nightly WAL documentation (English + Chinese) to reflect the Kafka remote WAL change that bounds requests with a 5s default total request timeout, and adds the related log-store latency histogram metric guidance.
Changes:
- Updated Kafka remote WAL
timeoutdefault from"3s"to"5s"and renamed the description to “total request timeout”. - Updated the global
wal.timeoutconfiguration docs to match the new"5s"default and wording. - Added
greptime_logstore_op_elapsed_bucketto performance tuning metrics, noting buckets extend through 60 seconds.
File summaries
| File | Description |
|---|---|
| i18n/zh/docusaurus-plugin-content-docs/current/user-guide/deployments-administration/wal/remote-wal/configuration.md | Chinese Remote WAL config: update timeout default and wording. |
| i18n/zh/docusaurus-plugin-content-docs/current/user-guide/deployments-administration/performance-tuning/performance-tuning-tips.md | Chinese performance metrics: add log-store latency histogram entry. |
| i18n/zh/docusaurus-plugin-content-docs/current/user-guide/deployments-administration/configuration.md | Chinese global config: update wal.timeout default and wording. |
| docs/user-guide/deployments-administration/wal/remote-wal/configuration.md | English Remote WAL config: update timeout default and wording. |
| docs/user-guide/deployments-administration/performance-tuning/performance-tuning-tips.md | English performance metrics: add log-store latency histogram entry. |
| docs/user-guide/deployments-administration/configuration.md | English global config: update wal.timeout default and wording. |
Review details
Suppressed comments (2)
docs/user-guide/deployments-administration/configuration.md:1010
- The
wal.timeouttable description should explicitly state that the timeout covers the entire request lifecycle (send + response wait), not just “operations”, to match the actual semantics change from GreptimeDB PR #9026.
| `wal.timeout` | String | `5s` | The total request timeout for kafka client.<br/>**It's only used when the provider is `kafka`**. |
i18n/zh/docusaurus-plugin-content-docs/current/user-guide/deployments-administration/configuration.md:997
wal.timeout的表格说明建议明确该超时覆盖完整的 Kafka 请求(发送请求帧与等待响应),与实现语义一致,减少用户将其误解为仅等待响应或单个操作超时。
| `wal.timeout` | String | `5s` | kafka 客户端的总请求超时时间。<br/>**仅在 provider 为 `kafka` 时使用。** |
- Files reviewed: 6/6 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@WenyXu Take a look. |
| | `overwrite_entry_start_id` | If true, the Datanode will skip over missing entries during WAL replay. Prevents out-of-range errors, but may hide data loss. | | ||
| | `connect_timeout` | The connect timeout for Kafka client. Default is `"3s"`. | | ||
| | `timeout` | The timeout for Kafka client operations. Default is `"3s"`. | | ||
| | `timeout` | The total request timeout for the Kafka client. Default is `"5s"`. | |
There was a problem hiding this comment.
GreptimeDB PR 9026 also adds connect_timeout and timeout to metasrv.example.toml and to the Metasrv section of config/config.md, and Metasrv's topic creator uses them for its Kafka client. The Metasrv Configuration section above (example and Options table) still lists neither key, so readers tuning Metasrv from this page miss the new 5s default. Consider adding both rows there as well, and the same on the Chinese page.
| | greptime_mito_write_stall_total | counter | The total number of write requests stalled due to high memory pressure or transient region states. | | ||
| | greptime_mito_write_reject_total | counter | The number of write requests rejected due to high memory pressure. | | ||
| | raft_engine_sync_log_duration_seconds_bucket | histogram | The elapsed time of flushing the WAL to the disk. | | ||
| | greptime_logstore_op_elapsed_bucket | histogram | The elapsed time of log-store operations. Finite latency buckets extend through 60 seconds. | |
There was a problem hiding this comment.
"Finite latency buckets extend through 60 seconds" describes the histogram's bucket layout, which no other row in this table does, and it doesn't say what the metric measures. Suggestion:
| | greptime_logstore_op_elapsed_bucket | histogram | The elapsed time of log-store operations. Finite latency buckets extend through 60 seconds. | | |
| | greptime_logstore_op_elapsed_bucket | histogram | The elapsed time of WAL log store operations, such as Kafka appends. Use the `logstore` and `optype` labels to separate stores and operation types. | |
The Chinese row (有限延迟桶扩展至 60 秒) reads as a literal translation and should be adjusted to match.
|
@copilot address comments |
Co-authored-by: WenyXu <32535939+WenyXu@users.noreply.github.com>
What changed
5s.greptime_logstore_op_elapsed_bucketand documented latency buckets extending through 60 seconds.Example:
Scope
Verification
Checklist