Skip to content

Fix large conversation load #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RankoR wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix large conversation load #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8f36098
Add a huge conversation to the debug data seeder
RankoR Sep 16, 2026
9b9f335
Group conversation messages by message id so part-less messages are n…
RankoR Sep 16, 2026
385bb85
Look up a single conversation message by id instead of walking the wh…
RankoR Sep 16, 2026
4994b65
Index messages by conversation and received timestamp in database ver…
RankoR Sep 16, 2026
ff76bac
Identify the tapped photo by part id instead of its occurrence index
RankoR Sep 16, 2026
6e93d58
Load conversation messages in a window that grows as the user scrolls…
RankoR Sep 16, 2026
e19d2e6
Scroll to the widget message position now that the newest messages lo…
RankoR Sep 16, 2026
2b846ba
Fix detekt and ktlint issues
RankoR Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...roidTest/java/com/android/messaging/ui/photoviewer/screen/PhotoViewerScreenContentTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ internal class PhotoViewerScreenContentTest {
isDraft: Boolean = false,
): PhotoViewerItem {
return PhotoViewerItem(
partId = "part-$index",
contentUri = photoViewerImageUri(),
contentType = IMAGE_JPEG,
isIncoming = isIncoming,
Expand Down
11 changes: 5 additions & 6 deletions ...ing/data/conversation/repository/conversations/ConversationsRepositoryDirectLookupTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import io.mockk.every
import io.mockk.mockk
import io.mockk.slot
import io.mockk.verify
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.test.runTest
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNull
Expand All @@ -32,7 +31,6 @@ import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner

@OptIn(ExperimentalCoroutinesApi::class)
@RunWith(RobolectricTestRunner::class)
internal class ConversationsRepositoryDirectLookupTest : BaseConversationsRepositoryTest() {

Expand All @@ -59,7 +57,7 @@ internal class ConversationsRepositoryDirectLookupTest : BaseConversationsReposi
context = mainDispatcherRule.testDispatcher,
) {
val metadataUri = MessagingContentProvider.buildConversationMetadataUri(
CONVERSATION_ID.value
CONVERSATION_ID.value,
)
val participantsUri = MessagingContentProvider
.buildConversationParticipantsUri(CONVERSATION_ID.value)
Expand Down Expand Up @@ -137,7 +135,7 @@ internal class ConversationsRepositoryDirectLookupTest : BaseConversationsReposi
context = mainDispatcherRule.testDispatcher,
) {
val metadataUri = MessagingContentProvider.buildConversationMetadataUri(
CONVERSATION_ID.value
CONVERSATION_ID.value,
)
val participantsUri = MessagingContentProvider
.buildConversationParticipantsUri(CONVERSATION_ID.value)
Expand Down Expand Up @@ -196,8 +194,9 @@ internal class ConversationsRepositoryDirectLookupTest : BaseConversationsReposi
runTest(
context = mainDispatcherRule.testDispatcher,
) {
val messagesUri = MessagingContentProvider.buildConversationMessagesUri(
CONVERSATION_ID.value
val messagesUri = MessagingContentProvider.buildConversationMessageUri(
CONVERSATION_ID.value,
"message-1",
)
val participantsUri = MessagingContentProvider
.buildConversationParticipantsUri(CONVERSATION_ID.value)
Expand Down
Loading