Skip to content

chore(functions): update dependencies in firebase, helloworld, and http - #4470

Open
angelcaamal wants to merge 4 commits into
mainfrom
deps-functions-firebase-helloworld-http
Open

angelcaamal wants to merge 4 commits into
mainfrom
deps-functions-firebase-helloworld-http

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes b/562120716
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. asset: pattern DEE Asset tagging - Pattern. labels Sep 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js engine requirement to >=20.0.0 and upgrades several dependencies and devDependencies across multiple package.json files. The review feedback points out critical issues where some of the specified versions, specifically c8 at ^12.0.0 and @google-cloud/functions-framework at ^5.0.0, do not exist on the npm registry and will cause installation failures. It is recommended to revert these to valid, existing versions as suggested.

Comment thread functions/firebase/helloAnalytics/package.json
Comment thread functions/helloworld/helloGCS/package.json
Comment thread functions/helloworld/helloGCS/package.json
Comment thread functions/http/corsEnabledFunction/package.json
Comment thread functions/http/corsEnabledFunction/package.json
Comment thread functions/http/uploadFile/package.json

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelcaamal
angelcaamal marked this pull request as ready for review September 18, 2026 21:23
@angelcaamal
angelcaamal requested review from a team as code owners September 18, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants