Skip to content

chore(spanner): update dependencies #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
angelcaamal wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(spanner): update dependencies #4466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions spanner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"*.js"
],
"engines": {
"node": ">=18"
"node": ">=20"
},
"scripts": {
"test-with-archived": "mocha system-test --timeout 1600000",
Expand All @@ -26,12 +26,12 @@
"@opentelemetry/exporter-trace-otlp-grpc": "^0.57.0",
"@opentelemetry/instrumentation": "^0.57.0",
"@opentelemetry/instrumentation-grpc": "^0.57.0",
"@opentelemetry/resources": "1.30.1",
"@opentelemetry/sdk-trace-base": "~1.30.1",
"@opentelemetry/sdk-trace-node": "^1.30.1",
"@opentelemetry/resources": "2.0.0",
"@opentelemetry/sdk-trace-base": "~2.0.0",
"@opentelemetry/sdk-trace-node": "^2.0.0",
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/core": "^1.30.1",
"chai": "^4.2.0",
"@opentelemetry/core": "^2.30.1",

@gemini-code-assist gemini-code-assist Bot Sep 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version ^2.30.1 for @opentelemetry/core does not exist on the npm registry. It appears to be a typo from changing the major version from 1 to 2 while keeping the minor/patch versions (1.30.1 -> 2.30.1). Please revert this to ^1.30.1 to avoid installation errors.

Suggested change
"@opentelemetry/core": "^2.30.1",
"@opentelemetry/core": "^1.30.1",
References
  1. Verify the existence and stability of package versions on the npm registry before flagging them as invalid or pre-release.

"chai": "^6.0.0",

@gemini-code-assist gemini-code-assist Bot Sep 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Chai v5 and above (including v6.0.0) are ESM-only. Since this project is configured as CommonJS (lacking "type": "module" in package.json), upgrading to chai v6.0.0 will cause tests to fail with ERR_REQUIRE_ESM when using require('chai'). Please keep chai at ^4.2.0 or migrate the project to ESM in a separate PR.

Suggested change
"chai": "^6.0.0",
"chai": "^4.2.0",

"mocha": "^9.0.0",
"p-limit": "^3.0.1"
}
Expand Down
Loading