Conversation
…ypes CallParticipantsInfoMenu lost its only call site in June 2023, when the participant invitation flow was removed from CallContainer and CallViewModel. Nothing in the SDK or the demo app has opened it since, and the debug preview is its only remaining reference. The same applies to the public CallParticipantInfoMode interface and to the ParticipantInfoAction hierarchy, which no UI emits anymore. Mark all three public declarations as deprecated with a warning so integrators get one release of notice before v2 removes them. The annotations do not change the API dump. The internal mode objects and the files themselves suppress the deprecation warnings they now trigger on their own supertypes. Only the files that v2 deletes are touched, so the later develop to develop-v2 merge resolves each of them by keeping the deletion. AND-1527
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
SDK Size Comparison 📏
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe PR adds WARNING-level deprecation annotations to participant information actions, modes, and the ChangesParticipant information deprecation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change only marks scheduled-for-removal APIs as deprecated and does not alter runtime behavior. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit marks the old paths clear Comment |
|

Goal
Refs AND-1527
CallParticipantsInfoMenulost its only call site in June 2023, when the participant invitation flow was removed fromCallContainerandCallViewModel. Since then nothing in the SDK or the demo app has opened it, and its only reference is a debug preview. The demo app shows its ownParticipantsDialoginstead.The v2 branch removes the menu and the types around it in #1838. This PR gives 1.x integrators one release of notice first.
Implementation
@DeprecatedwithWARNINGlevel on the three public declarations that go away in v2:CallParticipantsInfoMenu, theCallParticipantInfoModeinterface, andParticipantInfoActionwith itsChangeMuteStateandInviteUserscases. Each message says the declaration is removed in v2; the menu message points atcall.state.participantsas the building block.developtodevelop-v2merge resolves each of them by keeping the deletion.InviteUsersToCallaction is left alone.Testing
No behaviour change, so there is nothing to try on a device. The deprecation warning shows up on any call to the three declarations, for example in
CallParticipantsInfoMenuPreviewin the compose module's debug source set. That preview is left as is on purpose, to keep the merge-down footprint to the three files above.Ran on
stream-video-android-ui-compose:spotlessApply(no edits),compileDebugKotlin,apiCheck.Summary by CodeRabbit
call.state.participantsfor participant data.