Fix JAVA_OPTS typo - #86
Open
jwkaltz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ParallelGCThreads flag in the default JAVA_OPTS was missing its leading dash ("XX:ParallelGCThreads=4"). The JVM treats a token without a leading dash as the main class, so it aborts at startup with:
This makes the default geoserver image fail to start. Deployments that override JAVA_OPTS via GEOSERVER_JAVA_OPTS mask the bug, which is presumably why it went unnoticed.
Regression introduced in #85.