Conversation
Signed-off-by: pushnanashi2 <relomeru.y@gmail.com>
aoto-tech
marked this pull request as ready for review
September 14, 2026 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this while reviewing the case API and reported it to the maintainers by email first. The list and detail handlers were the only case routes that did not call
require_permission, so requests without a token reached the repository layer.I added
require_permission("cases", "read")to both handlers and updated the existing case tests to use an admin token. I also added a test that checks both GET routes return 401 without authentication.pytest core/tests/test_api_routers/test_cases.py -q -k require_authenticationpasses with 2 tests.compileallandgit diff --checkpass too. I tried the full case test file, but Docker Desktop was not running, sotestcontainersfailed while starting PostgreSQL before the tests ran.Closes #147