Skip to content

fix(nix): omit FREESMLAUNCHER_JAVA_PATHS when jdks is empty - #233

Open
wongcallum wants to merge 1 commit into
FreesmTeam:developfrom
wongcallum:fix/nix-empty-jdks
Open

wongcallum wants to merge 1 commit into
FreesmTeam:developfrom
wongcallum:fix/nix-empty-jdks

Conversation

@wongcallum

Copy link
Copy Markdown

When I tried overriding the freesmlauncher package to set jdks = [], I got:

error: Cannot build '/nix/store/ysrqcwzv8zg9sis5linrhpvnc9hyl79d-freesmlauncher-616e092.drv'.
       Reason: builder failed with exit code 1.
       > <stdin>:61:6: error: #error makeCWrapper: Unknown argument PATH
       > <stdin>:62:6: error: #error makeCWrapper: Unknown argument :
       > <stdin>:63:6: error: #error makeCWrapper: Unknown argument /nix/store/...

This can be fixed by only setting FREESMLAUNCHER_JAVA_PATHS if the list is not empty.

Signed-off-by: Callum Wong <mail@callumwong.com>
@s0me1newithhand7s

Copy link
Copy Markdown
Member

i think it's better to make assertion to not let jdks be empty at all

@wongcallum

Copy link
Copy Markdown
Author

But I want to use my own Java :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants