Conversation
Signed-off-by: Tuwum <tuwum@wairu.space>
Member
|
So, this is a GUI wrap around a single Java argument. Do we need it? @notwindstone @s0me1newithhand7s |
Member
fuck no lol |
Member
yeah why not |
Member
|
thank you for your contribution! |
Signed-off-by: Tuwum <tuwum@wairu.space>
notwindstone
approved these changes
Sep 10, 2026
Signed-off-by: Tuwum <tuwum@wairu.space>
windstone-aristotle-yellow
approved these changes
Sep 12, 2026
notwindstone
approved these changes
Sep 12, 2026
so5iso4ka
requested changes
Sep 13, 2026
so5iso4ka
left a comment
so5iso4ka
left a comment
Member
There was a problem hiding this comment.
JEMALLOC_LIBRARY_NAME should be initialized here https://github.com/FreesmTeam/FreesmLauncher/blob/c26db526dca806ff52b51fd56b0516ed5d39562e/buildconfig/BuildConfig.cpp.in#L123-L122
Member
|
In addition, LWJGL expects jemalloc with symbols prefixed by "je_", whereas most jemalloc packages on Linux are built without this prefix. I think it's worth noting this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.