Skip to content

PathStrings: guard drive-letter normalization by platform - #231

Merged
ForNeVeR merged 3 commits into
ForNeVeR:mainfrom
hamdiakin:fix/non-windows-drive-letter-normalization
Sep 22, 2026
Merged

ForNeVeR merged 3 commits into
ForNeVeR:mainfrom
hamdiakin:fix/non-windows-drive-letter-normalization

Conversation

@hamdiakin

Copy link
Copy Markdown
Contributor

Summary

  • recognize drive-letter prefixes only when normalizing Windows paths
  • keep the normalization core deterministic with an explicit drive-letter check
  • cover Windows-style and Unix-style colon handling plus current-platform dispatch

Tests

  • dotnet build --no-restore
  • dotnet test --no-restore (262 passed)
  • dotnet format --no-restore --verify-no-changes --include TruePath/PathStrings.cs TruePath.Tests/PathStringsTests.cs

Closes #219

@ForNeVeR
ForNeVeR self-requested a review September 21, 2026 20:43
@ForNeVeR ForNeVeR self-assigned this Sep 21, 2026
@ForNeVeR

Copy link
Copy Markdown
Owner

Will you please take a look at the warnings in the code? See the nowarn-empty build job.

@ForNeVeR ForNeVeR assigned hamdiakin and unassigned ForNeVeR Sep 21, 2026
@ForNeVeR ForNeVeR assigned ForNeVeR and unassigned hamdiakin Sep 22, 2026

@ForNeVeR ForNeVeR left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR
ForNeVeR merged commit c5501a0 into ForNeVeR:main Sep 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path normalization should not check drive letter on non-Windows

2 participants