ci: pin review-workflow actions to commit SHAs; state the real merge gate - #28
Merged
Merged
Conversation
…gate (#26) Both third-party actions ran off mutable tags in a job holding pull-requests:write and the review token — one repointed tag upstream is a compromise of every repo carrying this workflow. Pinned: - actions/checkout @ 11d5960a326750d5838078e36cf38b85af677262 (# v4) - anthropics/claude-code-action @ 5ee796a55f92566ecd7e39d70dd613abcbea0d7c (# v1) The claude-code-action pin is what v1 resolves to TODAY — a pure pin for this repo, not an upgrade. (The tag has in fact moved since issue #26 was filed, which is the risk demonstrating itself; code-push-admin and -website pinned the earlier d40ddef4c030 — org-wide alignment is a separate deliberate bump.) The prompt also told reviewers Medium findings 'don't block the merge', which erases the paper trail the real rule requires. Both gate sentences now state the actual policy: Critical always blocks; up to two open Mediums may merge only if each unfixed one is filed as its own deferred-medium issue first; three or more block. id-token:write is deliberately untouched (removing it broke the review with 'Could not fetch an OIDC token' when tried on the template repos).
Contributor
Author
|
Local review of record (the bot deliberately skips own-workflow PRs — anti-injection guard; its 8s pass above is that skip). Multi-agent adversarial review of this diff, findings verified against the live actions state:
Verdict: 0 Critical / 0 Medium / 0 Low confirmed. Gate satisfied — merging. |
Contributor
Author
|
Local review of record (the bot skips this PR under its own-workflow anti-injection guard, so this multi-agent local review stands in — 3 finders × 2 adversarial skeptics each). Result: 0 Critical / 0 Medium / 0 confirmed findings.
✅ CI green, mergeable CLEAN. Gate satisfied — merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26, porting the fixes already merged on code-push-admin (#19) and code-push-website (#31) onto this repo's workflow (on top of #24's model routing — untouched).
actions/checkoutandanthropics/claude-code-actionwere tag-pinned in a job holdingpull-requests: writeandCLAUDE_CODE_OAUTH_TOKEN. Both now pin full commit SHAs with the tag as a trailing comment. The claude-code-action pin is whatv1resolves to today (5ee796a…) — a pure pin for this repo, not an upgrade. Notably the tag has already moved since issue CI: review workflow pins actions to mutable tags and states the wrong merge gate #26 was filed (the issue recordedd40ddef…) — the mutable-tag risk demonstrating itself; admin/website carry the earlier SHA, and aligning all repos is left as a separate deliberate bump (noted in a workflow comment).deferred-mediumissue first; ≥3 block. Also fixed the Critical section's "Only Critical findings block" sentence (admin template).id-token: writedeliberately untouched per the issue's warning (removal broke the review with OIDC-token fetch failures on the template repos)./code-reviewresult will be posted on this PR instead; do not read an absent bot comment as a pass. YAML validated; diff is workflow-only.