Conversation
|
Open
javier-godoy
marked this pull request as draft
September 24, 2026 18:11
javier-godoy
marked this pull request as ready for review
September 24, 2026 18:29
paodb
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
v25profile (Vaadin 25.0.0, Java 21, commons-demo 5.2.0), as in the other add-ons.The
build-vaadin25job added in 6678bc1 runsmvn -B package -Pv25, but the profile did not exist, so Maven only warned about it and the job built against Vaadin 24.🤖 Generated with Claude Code