Skip to content

build: remove TestBench dependencies from the published POM - #181

Merged
javier-godoy merged 2 commits into
masterfrom
dev-nuke
Sep 24, 2026
Merged

javier-godoy merged 2 commits into
masterfrom
dev-nuke

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Mark the TestBench dependencies as <?dev-only?> and add dev-nuke-maven-plugin, so that they are removed from the published POM.

Reference: FlowingCode/CommonsDemo@ab627d1

See https://github.com/FlowingCode/AddonsInternal/issues/214
See https://github.com/FlowingCode/AddonsInternal/issues/215

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated development build configuration for test-related tooling and development-only artifacts. There are no changes to the application’s runtime behavior or user-facing features.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7f8e85d6-3108-44bd-ac1c-300e77caa6a4

📥 Commits

Reviewing files that changed from the base of the PR and between 23d0763 and 4681af3.

📒 Files selected for processing (1)
  • pom.xml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6251279a-7ca1-448e-bd6e-e4774299ca5d

📥 Commits

Reviewing files that changed from the base of the PR and between fb451be and 23d0763.

📒 Files selected for processing (1)
  • pom.xml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The Maven configuration marks vaadin-testbench and testbench-rpc as dev-only. It also adds the dev-nuke-maven-plugin with an execution bound to the dev-nuke goal.

Changes

Dev-only build configuration

Layer / File(s) Summary
Mark dev-only dependencies and configure cleanup
pom.xml
The vaadin-testbench and testbench-rpc dependencies gain dev-only processing instructions. The build adds version 1.0.0 of the dev-nuke-maven-plugin and binds its dev-nuke goal.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: flowingcodeci

Merge Risk: ⚪ Minimal · up to 23d07

The published POM excludes the two dev-only dependencies. No merge-blocking issue remains after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main build change: removing TestBench dependencies from the published POM.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@javier-godoy javier-godoy self-assigned this Sep 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

@javier-godoy
javier-godoy merged commit 62a90ac into master Sep 24, 2026
7 checks passed
@javier-godoy
javier-godoy deleted the dev-nuke branch September 24, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

1 participant