Skip to content

Add macos mypy check (petsc4py + superlu_dist) - #4095

Open
schnellerhase wants to merge 4 commits into
mainfrom
schnellerhase/petsc4py-stubs
Open

Add macos mypy check (petsc4py + superlu_dist)#4095
schnellerhase wants to merge 4 commits into
mainfrom
schnellerhase/petsc4py-stubs

Conversation

@schnellerhase

@schnellerhase schnellerhase commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@schnellerhase schnellerhase self-assigned this Feb 17, 2026
@schnellerhase schnellerhase added type-hints dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Feb 17, 2026
@schnellerhase
schnellerhase force-pushed the schnellerhase/petsc4py-stubs branch 2 times, most recently from 1eb9a9e to f5bb03c Compare February 17, 2026 21:44
@schnellerhase
schnellerhase force-pushed the schnellerhase/petsc4py-stubs branch from f50261c to 56546f4 Compare May 1, 2026 10:21
@schnellerhase schnellerhase mentioned this pull request May 15, 2026
Merged
@schnellerhase
schnellerhase force-pushed the schnellerhase/petsc4py-stubs branch from 56546f4 to 4a8fab2 Compare May 15, 2026 12:42
@schnellerhase
schnellerhase force-pushed the schnellerhase/petsc4py-stubs branch 3 times, most recently from 196d179 to fe32890 Compare July 20, 2026 14:00
github-advanced-security[bot]
github-advanced-security AI found potential problems Jul 20, 2026
View reviewed changes
Comment thread .github/workflows/macos.yml Fixed
Comment thread .github/workflows/macos.yml Fixed
@schnellerhase
schnellerhase force-pushed the schnellerhase/petsc4py-stubs branch from fe32890 to ef2f517 Compare July 21, 2026 10:36
Copilot AI lite review requested due to automatic review settings August 4, 2026 18:21
Copilot AI reviewed Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 4, 2026 18:25
Copilot AI reviewed Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 4, 2026 18:26
Copilot AI reviewed Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

schnellerhase
schnellerhase commented Aug 8, 2026
View reviewed changes
Comment thread .github/workflows/macos.yml Outdated
schnellerhase
schnellerhase commented Aug 8, 2026
View reviewed changes
Comment thread .github/workflows/macos.yml Outdated
schnellerhase
schnellerhase commented Aug 8, 2026
View reviewed changes
Comment thread .github/workflows/macos.yml Outdated
schnellerhase
schnellerhase commented Aug 15, 2026
View reviewed changes
Comment thread python/dolfinx/fem/petsc.py Outdated
schnellerhase
schnellerhase commented Aug 15, 2026
View reviewed changes
Comment thread python/dolfinx/fem/petsc.py
schnellerhase
schnellerhase commented Aug 15, 2026
View reviewed changes
Comment thread python/dolfinx/fem/petsc.py
@schnellerhase
schnellerhase force-pushed the schnellerhase/petsc4py-stubs branch from 7c28d97 to 622ac5a Compare August 15, 2026 10:54
@schnellerhase schnellerhase changed the title petsc4py stubs Add macos mypy check (petsc4py + superlu_dist) Aug 15, 2026
@schnellerhase
schnellerhase marked this pull request as ready for review August 15, 2026 10:57
@garth-wells

garth-wells commented Aug 16, 2026

Copy link
Copy Markdown
Member

Does adding a mypy check to macOS provide any meaningful extra coverage?

@schnellerhase

schnellerhase commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

It covers the optional dependency case petsc4py + superlu_dist - why have the other mypy checks been (re-)moved in #4414?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@garth-wells garth-wells Awaiting requested review from garth-wells
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@schnellerhase schnellerhase

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code type-hints

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adapt to availability of petsc4py stubs

4 participants

@schnellerhase @garth-wells @github-advanced-security