SPIN-5582: Strip html from database values. Keep html in specific renderer output. - #33
Open
bartleenheer wants to merge 4 commits into
Open
SPIN-5582: Strip html from database values. Keep html in specific renderer output.#33bartleenheer wants to merge 4 commits into
bartleenheer wants to merge 4 commits into
Conversation
… isn't configured. * Now also works when only setRenderer is used * Now also works when no renderer is used
bartleenheer
commented
Aug 31, 2026
bartleenheer
left a comment
bartleenheer
left a comment
Author
There was a problem hiding this comment.
Look if we can reduce the amount of nested for-loops
Comment on lines
+226
to
+239
| private function _markRendererOutputAsSafe(array &$data, array $raw_data) | ||
| { | ||
| foreach ($data as $row_index => &$row) | ||
| { | ||
| foreach ($row as $column_index => &$value) | ||
| { | ||
| $original = $raw_data[$row_index][$column_index] ?? null; | ||
| if (is_string($value) && $value !== $original) | ||
| { | ||
| $value = new Markup($value, 'UTF-8'); | ||
| } | ||
| } | ||
| } | ||
| } |
Comment on lines
+254
to
+266
| private function _escapeUnsafeValues(array &$data) | ||
| { | ||
| foreach ($data as &$row) | ||
| { | ||
| foreach ($row as &$value) | ||
| { | ||
| if (is_string($value)) | ||
| { | ||
| $value = htmlspecialchars($value, ENT_QUOTES, 'UTF-8'); | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.