fix(earthquake): localize and align report day headers - #575
Merged
Merged
Conversation
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
|
PiscesXD
force-pushed
the
fix/earthquake-report-header
branch
from
September 17, 2026 15:57
0616d69 to
2272a50
Compare
PiscesXD
force-pushed
the
fix/earthquake-report-header
branch
from
September 19, 2026 06:03
2272a50 to
197dc58
Compare
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
這個 PR 也修復了 ET-2026-0164 DPIP防災 26.3 EEW時圖層問題 |
Fix(zh-Hant): 地震報告日期與筆數固定對齊 Fix(en-US): align earthquake report dates and counts consistently
Fix(zh-Hant): 地震報告列表的日期標題不再在日期後面留一段空白 Fix(en-US): the report list's day heading no longer leaves a gap after the date
Fix(zh-Hant): 強震監視器與報告回放地圖的鄉鎮名稱不再蓋住測站讀數 Fix(en-US): township names no longer cover the station readings on the monitor and replay maps
PiscesXD
force-pushed
the
fix/earthquake-report-header
branch
from
September 19, 2026 19:46
2401677 to
d26e4b0
Compare
lowrt
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
lib/shared/map/monitor_map_stack.dart),鄉鎮名稱不再蓋住測站讀數。地圖圖層顯示順序
這個堆疊的順序本身就是契約。所有圖層一律用 append(不帶
belowLayerId),插入順序即決定疊放,後加的在上。由下而上:townfill 原地改色,所以同樣留在名稱底下。鄉鎮名稱因此落在整張圖的倒數第二層:在底色之上、所有讀數之下。rts-eew-s-fill,錨在landLayerId之下,讓水波只鋪在外海,不蓋住台灣本島。iconIgnorePlacement,不參與碰撞,也就不會反過來壓掉地名。怎麼驗
tool/dev/test.sh test/features/earthquake/report_day_group_test.darttool/dev/test.sh test/features/map/presentation/layers/rts_layer_demo_test.dart(9 passed)every monitor layer is appended above the township names, except the S-wave disc anchored below the land—— 逐一斷言七個圖層的belowLayerId為 null(代表 append 到 style 最上層,落在底圖town-label之上),並斷言rts-eew-s-fill確實錨在landLayerId。the epicentre cross stacks above the box grid, which stacks above the station dots — matching the legacy monitor—— 釘住由下而上的相對順序。the grey island stays opaque under the shaking wash, so the S-wave disc cannot bleed through a township reading—— 確認 S 波圓盤不會透到陸地上的鄉鎮讀數。tool/dev/analyze.shtool/commit.sh(完整測試 1835 passed)tool/check/commits.sh origin/main..HEADAppLocalizations與intllocale,沒有新增硬編碼語系文字檢查清單
AppSpacing/AppRadius,並處理窄螢幕與寬螢幕排版