Conversation
Fixes the information disclosure half of EssentialsX#6626: /whois sent exact player coordinates to anyone holding essentials.whois. A new essentials.whois.location node now guards the location line, matching the existing essentials.seen.location design. Console and non-player senders are unaffected.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the information disclosure half of #6626: /whois sent exact player coordinates to anyone holding essentials.whois. A new essentials.whois.location node now guards the location line, matching the existing essentials.seen.location design. Console and non-player senders are unaffected.
Information
This PR partially addresses #6626.
Details
Proposed fix:
Guard the
whoisLocationline inCommandwhoisbehind a newessentials.whois.locationpermission node (registered inplugin.yml), matching the existingessentials.seen.locationdesign. Behaviour note: players withessentials.whoispreviously saw coordinates by default; after this change they need the new node. Console and non-player senders are unaffected (CommandSource.isAuthorizedauto-allows them).The cooldown-bypass half of #6626 (
AsyncTeleport.cooldownApplies()) is intentionally left out and will follow as a separate PR.Environments tested:
OS: Windows 11 25H2
Java version: 26.0.1 (server ran on Paper's bundled Java 25 runtime path; built with Temurin 25.0.4.1)
Demonstration:
Live-server repro via two bots (Victim, Tester) + LuckPerms,
teleport-cooldown: 10, EssentialsX2.22.1-dev+24-49a2f10(unpatched) vs this branch (patched):Before (unpatched) — Tester holds only
essentials.whois, runs/whois Victim(victim at 120.5, 67, -458.5):- 坐标:(world,120, 67, -459)← leak confirmedAfter (patched) — same setup, location line hidden; then granting
essentials.whois.location:- 坐标:(world,200, 68, 300)← node restores it, Victim2 at 200, 68, 300Negative control: clearing all Tester permissions →
/whoisdenied (你没有使用该命令的权限), ruling out OP/config contamination. Full repro steps in my comment on #6626.