ci: Add github action for tagging every merged PR - #287
Conversation
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Consider using an already existing solution like https://github.com/mathieudutour/github-tag-action or https://github.com/anothrNick/github-tag-action.
| jobs: | ||
| tag: | ||
| if: github.event.pull_request.merged == true | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Do we even need to specify this?
17af99e to
2528064
Compare
|
If we decide to stick with this option, we should use custom_release_rules to create a PR title trigger for major versions. On the other hand... if we want an all-in-one solution (PR title linting, automatic versioning, etc) the industry standard seems to be https://github.com/semantic-release/semantic-release, albeit its a significantly more complex tool. Edit: NVM, it seems like semantic-release has no linting. So what I've suggested matters a little less. |
2528064 to
8ee5bff
Compare
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
LGTM. This is a rather invasive change for our workflow -- if it doesn't work out, we should revert it. But for now, I'm in favour of giving this a shot.
We removed any trailing bits from semantic versioning as requested. With features like this, the test of pudding is in eating. We tried this out on a throwaway repo, and it works as advertised; if we later decide the this isn't a good fit for this repo, we could adjust or revert it altogether.
furtib
changed the title
3 participants
Why:
We want to tag every commit made to main for easier integration and testing for end users.
What:
Use the date and time for the tag name.
Addresses:
#285