Prototype Bazel-native FOSS tests - #209
Conversation
|
Hi @furtib and @Szelethus, |
There was a problem hiding this comment.
I like the idea, haven't thought of it in this way.
But why do it in a separate folder?
(minor note, due to how the CI is set up, it doesn't actually run these tests)
It also does not work on the Bazel 6 version, since we don't use the WORKSPACE file at all.
Just now I realized, tests is only used to disable the per-file test in yaml-cpp?
Let me show what I'm thinking of. (tomorrow...)
Szelethus
left a comment
There was a problem hiding this comment.
I like the approach! Would it be okay if, while preserving the main idea, we polished the PR up?
|
The approach is actually questionable - run bazel from bazel. Anyway, I have 2 conclusions in mind:
|
|
Sure! Lets think of a solution that is actionable and can be implemented incrementally. I don't mean this to come off the wrong way, but our bazel 8 support project showed how striving for perfection was the enemy of progress. Our foss tests so far have borne some fruit, even if they are imperfect. |
3c9949d to
fbfd8dd
Compare
Szelethus
left a comment
There was a problem hiding this comment.
Now that we are through the prototype phase, I suppose this can just replace the existing FOSS tests, right?
Also, whats the rationale behind the test/bazel/ directory instead of test/foss?
Agree, I will replace tests in |
Why: The existing Python/Bash FOSS tests are hard to understand and extend, they are also very slow and cannot be integrated into Bazel environment. What: Add test/bazel/ with a foss_test() macro that generates sh_test() targets for FOSS projects. Test: bazel test //test/bazel/... Convert to py_test() Fix buildifier issues
c690161 to
5414e74
Compare
Why:
The existing Python/Bash FOSS tests are hard to
understand and extend, they are also very slow
and cannot be integrated into Bazel environment.
What:
Add test/bazel/ with a foss_test() macro
that generates py_test() targets for FOSS projects.
Test:
bazel test //test/bazel/...