MacOS make check-source fixes - #9379
Open
sangbida wants to merge 2 commits into
Open
Conversation
Shellcheck 0.11 (SC2268) rejects the old x"$1" comparison idiom. Prevents: "tests/plugins/compacter-slow.sh:5:6: note: Avoid x-prefix in comparisons as it no longer serves a purpose. [SC2268]"
Apple's make/patch are too old for the build and check-source; install gpatch and put both Homebrew gnubin dirs on PATH.
Collaborator
|
I can not reproduce the It gives me the same output as on my own debian machine. What is the exact command you use for Afaik it should be: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x"$1"idiom incompacter-slow.sh(ShellCheck SC2268).make+gpatchon macOS socheck-sourceworks locally.CI does not hit these, so the failures show up mainly for local macOS contributors.
Changelog-None