Merge the two hook-freshness flags into one - #747
Merged
mergify[bot] merged 1 commit intoSep 17, 2026
Conversation
CATSTACK_HOOK_FRESHNESS now takes off, local, or fetch. local is the default and never touches the network; fetch replaces CATSTACK_HOOK_FRESHNESS_FETCH=1; off (and the old 0) silences the hook. The retired name and unknown values are named in the advisory instead of being dropped silently. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: I960a699d2a6b4cef1b620fcac3e1f1e349d52af5
Owner
Author
|
This pull request is part of a Mergify stack:
|
2 tasks
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Owner
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 6 minutes 52 seconds in the queue, including 6 minutes 18 seconds running CI. Required conditions to merge
|
6 tasks
Owner
Author
|
@Mergifyio queue admin-bypass |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A helper warns when this project's copy on your computer is out of date. One setting now turns it off, keeps it offline, or lets it check online first.
Having two settings for one helper made it hard to see which one wins.
Now one setting takes three words. The old second setting is ignored, and the warning says so.
Review Claim
One setting picks between off, offline, and check online first for the out-of-date warning.
Review Lane
behavior
Review Unit
engine-runtime
Safety Invariant
The hook only gives advice and never goes online unless the flag says
fetch.Slice Rationale
Bottom of a two-PR stack; the root README row follows as its own review unit.
CATSTACK_HOOK_FRESHNESS=off|local|fetch, defaultlocal.0still meansoff.fetchreplacesCATSTACK_HOOK_FRESHNESS_FETCH=1. A leftover_FETCHand unknown values are named in the advisory, never dropped silently.Non-goals
.envfiles is not added here.Test Plan
Test Plan
python3 -m unittest discover -s engine/hooks/hook-freshness/testsbefore the fix:python3 scripts/ci/check_hook_test_coverage.py engine/hooks/hook-freshness→OK (1 hook(s) checked)python3 engine/skills/make-pr/scripts/preflight.py --base origin/main→unit engine-runtime: 3 file(s), all gates okRevert Plan
Revert Plan
git revert <sha>CATSTACK_HOOK_FRESHNESS_FETCH=1again iffetchwas in use.🤖 Generated with Claude Code