cat-mode: name the on setting of its default flag - #745
Merged
Conversation
2 tasks
Owner
Author
|
This pull request is part of a Mergify stack:
|
6 tasks
EdbertChan
changed the title
EdbertChan
force-pushed
the
stack/EdbertChan/flags/cat-mode-flag/give-catstack-cat-mode-default-three-settings--afccb934
branch
from
September 17, 2026 01:50
fb4dcca to
c571574
Compare
EdbertChan
force-pushed
the
stack/EdbertChan/flags/cat-mode-flag/cat-mode-name-setting-catstack-cat-mode-default--2ca516b6
branch
from
September 17, 2026 01:50
40755b4 to
6d99923
Compare
EdbertChan
changed the title
Owner
Author
Revision history
|
EdbertChan
changed the title
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: I2ca516b6d74a6da33b56803e261b30cb00cf616c
EdbertChan
changed the base branch from
stack/EdbertChan/flags/cat-mode-flag/give-catstack-cat-mode-default-three-settings--afccb934
to
main
September 17, 2026 04:21
EdbertChan
changed the title
EdbertChan
force-pushed
the
stack/EdbertChan/flags/cat-mode-flag/cat-mode-name-setting-catstack-cat-mode-default--2ca516b6
branch
from
September 17, 2026 04:21
6d99923 to
c610509
Compare
EdbertChan
changed the title
Owner
Author
|
@Mergifyio queue admin-bypass |
Contributor
Merge Queue Status
This pull request spent 6 minutes 45 seconds in the queue, including 4 minutes 25 seconds running CI. Required conditions to merge
|
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The work style guide names the new word for its always-on setting.
Before, the guide said to turn it on with a one. That still works, but the documented word is now on.
The guide line and the test that checks it now say on.
Review Claim
The work style guide names the always-on setting by its new word.
Review Lane
behavior
Review Unit
corpus-lesson
Safety Invariant
Only the wording of one line changes;
1still meanson, so nothing a user set stops working.Slice Rationale
Middle of a three-PR stack, on top of the flag change. It holds only
corpus/skills/cat-mode/SKILL.mdand the test intests/test_cat_mode.pythat pins that line.Non-goals
Test Plan
Test Plan
python3 -m unittest tests.test_cat_mode→OK(80 tests)python3 engine/skills/make-pr/scripts/preflight.py --base <#744 branch>→unit corpus-lesson: 1 file(s), all gates okRevert Plan
Revert Plan
git revert <sha>🤖 Generated with Claude Code
Depends-On: #744