Turn drafter-core PR rules off unless CATSTACK_DRAFTER_CORE=1 - #742
Open
EdbertChan wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: I3014f5c0e39f0455d272929d35482b1dedc80557
Owner
Author
|
This pull request is part of a Mergify stack:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR drafting tools now skip the outside PR rule package unless a new setting turns it on. When skipped, they print a clear "unchecked" line.
The repo's own summary checks still run. The template tool stops with an "unchecked" exit so nobody mistakes an empty template for a real one.
Review Claim
With the new setting off, the PR drafting tools skip the outside rule package and say so, and turn it back on when the setting is on.
Review Lane
behavior
Review Unit
engine-runtime
Safety Invariant
With
CATSTACK_DRAFTER_CORE=1every script runs the same drafter-core rules as before; with it off, no check reports clean for rules it skipped.Slice Rationale
The flag and every script that reads it change together, so the setting means one thing. The README flag row is its own docs PR stacked on this one.
Non-goals
preflight.pyreview-unit rules, which readdrafter.config.jsondirectly.Test Plan
Test Plan
python3 -m unittest -k flag_off engine/skills/draft-pr/tests/test_draft_pr_scripts.py tests/test_validate_pr_body_local.py→FAILED (failures=3)Ran 60 tests ... OKbash scripts/test/run_all_tests.sh→ exit 0, noFAILEDlineslint-diff-atomicity.mjsprintsUNCHECKED: drafter-core rules skipped (CATSTACK_DRAFTER_CORE is off; ...)exit 0;pr-body-template.mjssame line, exit 3Diff atomicity validation passed.exit 0; template prints## Summaryexit 0python3 engine/skills/make-pr/scripts/preflight.py --base origin/main --body-file <this body>Revert Plan
Revert Plan
git revert <sha>🤖 Generated with Claude Code