Remove incorrect use of CASEROOT in 'bld/configure' - #1641
Open
briandobbins wants to merge 1 commit into
Open
Conversation
…iable, not an environment variable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty unimportant change, but jumped out when looking at build warnings (which it doesn't actually change).
I noticed that the include path had "-I/SourceMods/sr.c.cam" on it, which turned out to be because of a failed expansion of CASEROOT, since it's a CIME variable, not an environment variable, so it $ENV{'CASEROOT'} expands to an emptry string.
The actual SourceMods/src.cam directory is included via the 'usr_src' bit, which is why everything still works.
Since all of this goes away with CAM-SIMA, if it's not worth merging now I understand, especially this close to release. I have some other PRs that will greatly reduce warnings that are reported on builds, but they go into other repos.