Restrict missing software check to after deploy label is set - #1505
Restrict missing software check to after deploy label is set#1505ocaisa wants to merge 15 commits into
Conversation
e01ba8e to
2cceb6e
Compare
|
To whomever reviews this, you can see that the the missing installation test is currently skipped. To force the check to run you add the label However, I would like to also make sure that we require the missing installations check before a PR is merge-able (which it seems like is not quite the status) |
|
Actually, it seems the the required checks are indeed held back, this PR should not be mergable even with a positive review |
|
I'm going to take this further, I plan to
|
| # Use GITHUB_OUTPUT heredoc correctly | ||
| echo "EESSI_VERSIONS<<EOF" >> "$GITHUB_OUTPUT" | ||
| echo "$EESSI_VERSIONS" >> "$GITHUB_OUTPUT" | ||
| echo "2025.06" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
I'm confused, why is this version hard-coded now? Or was that part of a test and should that change be reverted?
There was a problem hiding this comment.
Ah, I remember, there are no changed easystacks, I needed to manually set this value to match the condition later
There was a problem hiding this comment.
Needs to be reverted before merge
Co-authored-by: Caspar van Leeuwen <33718780+casparvl@users.noreply.github.com>
|
Ugh, there's a conflict. Could you look into it? I don't want to accidentally select the wrong parts in your PR :) |
No description provided.