Skip to content

fix(vmm): bound automatic restart retries - #968

Merged
kvinwang merged 7 commits into
masterfrom
codex/fix-vmm-restart-policy
Aug 6, 2026
Merged

fix(vmm): bound automatic restart retries#968
kvinwang merged 7 commits into
masterfrom
codex/fix-vmm-restart-policy

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Problem

VMM automatically restarted a repeatedly failing VM without a retry bound. A permanent boot error caused an infinite restart loop, resource churn, and noisy logs.

Root cause and fix

Track automatic restart attempts and stop retrying after the configured bound while reporting the terminal failure.

Implementation

The branch records the following focused implementation work:

  • fix(vmm): bound automatic restart retries
  • fix(vmm): validate automatic restart timing
  • test(vmm): exercise automatic restart policy matrix
  • test(vmm): keep restart coverage focused

Changed paths:

  • dstack/vmm/src/app.rs
  • dstack/vmm/src/config.rs
  • dstack/vmm/src/main.rs
  • dstack/vmm/vmm.toml

Scope

This PR addresses one logical vmm finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

This PR is based directly on master and does not require another split product PR to merge first.

Verification

  • git diff --check origin/master..origin/codex/fix-vmm-restart-policy: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 03:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang force-pushed the codex/fix-vmm-restart-policy branch from be174aa to efc62ed Compare August 6, 2026 03:05
@kvinwang
kvinwang merged commit 711f5f9 into master Aug 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants