Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR brings a much-needed visual polish to the Deployments Overview tab, making the layout cleaner, more responsive, and eliminating layout shifts. It also includes several code cleanliness improvements under the hood.
UI / UX Enhancements
md+screens): Moved the search bar and filter selects to sit perfectly side-by-side with the Tabs (Deployments | Queue) on tablets and desktops. This utilizes the horizontal real estate better and feels much more native.pt-4) above the content tables on both the Deployments and Queue subtabs. Previously, switching between these tabs caused the table to physically jump up and down by 8px. It is now completely stable.Code Refactoring
flex flex-col md:flex-row), eliminating the need to duplicate complex DOM nodes for mobile/desktop.columnFilters,globalFilter) and their corresponding imports fromshow-deployments-table.tsxsince filtering is already manually handled viauseMemo.<div className="space-y-2">from the Deployments table that was contributing to margin-collapse issues.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
N/A
Screenshots (if applicable)
The PR appears safe to merge; the previously reported tablet overflow is fully fixed and no new actionable issues were identified.
Summary
lgbreakpoint for the single-row layout, resolving the tablet-width overflow reported previously.Reviews (2) · Last reviewed commit: "fix(ui): change filter layout breakpoint..."