Skip to content

fix(dgw): reject null event source handles #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Benoît Cortier (CBenoit) wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(dgw): reject null event source handles #1972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion crates/sysevent-winevent/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ impl WinEvent {
// SAFETY: Proper UTF-16, null-terminated string.
let handle = unsafe { EventLog::RegisterEventSourceW(std::ptr::null(), source_name_utf16.as_ptr()) };

if handle == windows_sys::Win32::Foundation::INVALID_HANDLE_VALUE {
if event_source_registration_failed(handle) {
return Err(SysEventError::Platform(format!(
"failed to register event source '{source_name}'"
)));
Expand Down Expand Up @@ -141,6 +141,10 @@ impl Drop for WinEvent {
}
}

fn event_source_registration_failed(handle: windows_sys::Win32::Foundation::HANDLE) -> bool {
handle.is_null()
}

fn severity_to_event_type(severity: Severity) -> u16 {
match severity {
Severity::Critical => EventLog::EVENTLOG_ERROR_TYPE,
Expand All @@ -159,6 +163,14 @@ fn to_null_terminated_utf16(input: &str) -> Vec<u16> {
mod tests {
use super::*;

#[test]
fn event_source_registration_failure_sentinel() {
assert!(event_source_registration_failed(std::ptr::null_mut()));
assert!(!event_source_registration_failed(
windows_sys::Win32::Foundation::INVALID_HANDLE_VALUE
));
}

#[test]
fn severity_to_event_type_mapping() {
assert_eq!(
Expand Down
Loading