Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Fixes DeusData#1642 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
17a326a to
43620d3
Compare
|
Thank you for improving this wording. Current UI labels say |
|
Switched to Refs #1642 in the description, thanks. You are right that the wording change does not establish the edge-completeness concern is fixed, so it should not auto-close the report. I also cleaned up the description while I was in there: a stray line from my own working notes had ended up in it, and the checklist was malformed. It now reflects the real state, including that CI is red on test-unix (macos-15-intel) and ci-ok, which I am looking at. |
What does this PR do?
Update
FilterPanel.tsxso the section is titled "Reference coverage", the candidate count reads "N with no known inbound references", and the existing filter reads "Show only nodes with no known inbound references". Add a short explanation in that section: "No known inbound references does not prove code is unused. Static analysis may miss constructors, implicit or framework calls, and callbacks." Change thedeadentry inSTATUS_LEGENDincolors.tsto "No known inbound references", and clarify the nearby status comment while retaining its existing key and color.The graph UI presents functions and methods with no known incoming CALLS, USAGE, or CALL_REFERENCE edges as definitively dead, even though constructors, runtime/framework dispatch, and callbacks can execute without those edges being extracted. The reporter found 50 false positives in 50 sampled nodes, and another user reproduced the constructor case on v0.10.8.
DeusData asked that the first fix remove false certainty at the presentation boundary and leave extraction improvements to separate graph-quality work. This PR is that first step. It does not repair missing graph edges, so it references the issue rather than closing it.
Refs #1642
Checklist
git commit -s) - required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)Not run locally. CI currently fails on
test / test-unix (macos-15-intel)andci-ok; I am looking at that.make -f Makefile.cbm lint-ci)Not run locally. CI
lint / lintandlint / lint-memboth pass.