Skip to content

test(fqn): guard against Unicode project-name collisions - #2219

Open
lorenzozanee wants to merge 1 commit into
DeusData:mainfrom
lorenzozanee:restore/pr-2192
Open

lorenzozanee wants to merge 1 commit into
DeusData:mainfrom
lorenzozanee:restore/pr-2192

Conversation

@lorenzozanee

@lorenzozanee lorenzozanee commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds regression coverage for issue #571 by asserting that distinct non-ASCII project path segments produce distinct validator-safe project names. The existing project-name implementation encodes non-ASCII bytes as hexadecimal, so CJK path segments remain part of the project identity instead of collapsing into the same ASCII slug.

Checklist

  • Every commit is signed off (git commit -s) — required, CI rejects
    unsigned commits (DCO, see CONTRIBUTING.md)
  • Tests pass locally (make -f Makefile.cbm test)
  • Lint passes (make -f Makefile.cbm lint-ci)
  • New behavior is covered by a test (reproduce-first for bug fixes)

Fixes #571

Supersedes #2192(原PR分支已删,按原提交重建)

@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@DeusData DeusData added maintainer-notes Internal observations and improvement notes parsing/quality Graph extraction bugs, false positives, missing edges priority/normal Standard review queue; useful PR with ordinary maintainer urgency. labels Sep 19, 2026
@DeusData

Copy link
Copy Markdown
Owner

Thank you for adding the Unicode collision regression. Current FQN encoding already contains the underlying Unicode handling, so this is valuable protection of an existing fix rather than a newly delivered runtime correction. We should keep #571's requested reporter verification separate and not close it solely because this test lands.

@DeusData

Copy link
Copy Markdown
Owner

Thank you — a guard against Unicode project-name collisions in FQNs is a sharp thing to think of, and 14 lines in one test file makes it easy to say yes to.

One blocker: the dco check.

Your commit carries no Signed-off-by trailer — the message is a headline with an empty body, so there is nothing for the check to parse. (Not the blank-line trap, where the sign-off sits outside the trailer block and git's parser skips it while grep still finds it; here there is no trailer at all.)

git commit --amend -s
git push --force-with-lease

Everything else is green (31 success, 1 skipped). Sign it off and I will merge it.

One question, genuinely curious rather than a review demand: does this guard fail today, or does it pin behaviour that is already correct? Both are worth having and I will take either — but they are different things, and if it is a pinning test I would like to say so in the merge so the next person reading it knows it was never a bug report.

#2241 and #2242 merged cleanly today with correct sign-offs — the habit is already there, these branches just predate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-notes Internal observations and improvement notes parsing/quality Graph extraction bugs, false positives, missing edges priority/normal Standard review queue; useful PR with ordinary maintainer urgency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project name strips non-ASCII (CJK) characters from path, resulting in truncated/unrecognizable names

2 participants