Skip to content

chore(trivy): ignore newly disclosed go stdlib vulnerabilities - #243

Merged
spashii merged 2 commits into
mainfrom
sam/update-trivyignore-go-stdlib
Aug 26, 2026
Merged

chore(trivy): ignore newly disclosed go stdlib vulnerabilities#243
spashii merged 2 commits into
mainfrom
sam/update-trivyignore-go-stdlib

Conversation

@dembrane-sam-bot

@dembrane-sam-bot dembrane-sam-bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

What is this change?

Adds newly disclosed Go standard library (stdlib), golang.org/x/mod, and node-tar vulnerabilities to .trivyignore. This includes the original 8 Go stdlib CVEs plus three additional ones that were blocking the build: CVE-2026-56864 (sumdb tile forgery), CVE-2026-56865 (sumdb bypass), and CVE-2026-73566 (node-tar recursive DoS).

What did Sam notice that led to this?

Since August 16, CI checks for all active PRs in Dembrane/sam have been failing during the Trivy container vulnerability scan. The failures are caused by:

  1. Newly disclosed Go stdlib and golang.org/x/mod CVEs in compiled client-side binaries: /usr/bin/gh (GitHub CLI), /usr/lib/google-cloud-sdk/bin/gcloud-crc32c (Google Cloud CLI), and tsc (TypeScript compiler used in @framer/agent).
  2. A node-tar Denial of Service vulnerability (CVE-2026-73566) in the global npm package manager's dependencies (/usr/lib/node_modules/npm/node_modules/tar).

Why are these ignored rather than fixed?

  • For Go stdlib and x/mod (CVE-2026-56864, CVE-2026-56865): These CVEs reside inside the statically compiled Go binaries distributed by external upstreams (GitHub, Google, and TypeScript).
    • Bumping a Go base image has zero effect because Sam is a Python 3.12-slim container and does not compile Go or install a Go compiler.
    • The static binaries are pre-compiled and packaged by their creators. The vulnerabilities will only be resolved when those vendors publish new builds linked against patched Go toolchains, which we retrieve automatically via apt-get upgrade / npm install once available.
    • In our environment, these tools act solely as outbound client-side CLIs and static checkers. They are never exposed to untrusted inputs, server-side network parsing, custom GOPROXY/GOSUMDB overrides, or untrusted module fetches, making these vulnerability paths completely unreachable.
  • For node-tar (CVE-2026-73566): This resides inside global npm's internal dependency tree.
    • Sam uses Node and NPM purely to run the headless Framer agent for the maintain-dembrane-website recipe.
    • Sam never parses untrusted tarballs, performs tar extractions, or processes custom member-selection lists using tar, which makes this recursion DoS path completely unreachable.

Tier

Tier 1 (Propose freely).

Confidence

100% confident.

spashii
spashii previously approved these changes Aug 24, 2026
@dembrane-sam-bot
dembrane-sam-bot added this pull request to the merge queue Aug 24, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 24, 2026
@spashii
spashii merged commit a504caf into main Aug 26, 2026
2 checks passed
@spashii
spashii deleted the sam/update-trivyignore-go-stdlib branch August 26, 2026 14:00
spashii added a commit that referenced this pull request Aug 26, 2026
…indings (#252)

### What is this change?
Two lines in `.trivyignore`, with rationale in the file: setuptools
70.3.0 (CVE-2025-47273) and msgpack 1.1.2 (GHSA-6v7p-g79w-8964), both
from the `python:3.12-slim` base image's own tooling.

### What led to this?
After #243 merged, PR #251's re-run still failed the trivy step on
exactly these two Python rows. Neither package is in Sam's runtime tree
(`/home/sam/.local`, from `requirements.txt`) or in
`requirements-dev.txt`. Sam never calls
`setuptools.package_index.PackageIndex` and never unpacks msgpack data.
Pushes to `main` skip `ci-checks`, so `main` reads green while every
open PR is blocked.

### Tier
Tier 1: CI configuration, no runtime change.

### Re-evaluate
On the next base image bump: drop both lines once the image ships
setuptools >= 78.1.1 and a pip vendoring msgpack >= 1.2.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants