fix: correct severity bar chart position in open_findings chart - #15601
Open
tejas0077 wants to merge 1 commit into
Open
fix: correct severity bar chart position in open_findings chart#15601tejas0077 wants to merge 1 commit into
tejas0077 wants to merge 1 commit into
Conversation
Bars were always rendered under the first X-axis category (Critical) regardless of actual severity. _vals() only extracted count values, discarding x-position info. Chart.js then placed all bars at index 0. Added _sevVals() which maps each [x, count] pair to the correct position in a zero-filled array of length equal to number of labels, so each severity bar renders under its correct X-axis category. Fixes DefectDojo#15547
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15547
Severity bars in the open_findings chart were always rendered under the first X-axis category (Critical) regardless of actual severity.
The root cause was _vals() extracting only the count value d[1] from each [x, count] pair, discarding the x-position. Chart.js then placed every dataset's single value at index 0 (Critical).
Added _sevVals(data, labels) which maps each [x, count] pair to the correct position in a zero-filled array matching the labels length, so each severity bar now renders under its correct X-axis category.
Manually traced the bug through _vals() and _sevStackedBar(). The fix correctly maps severity index to chart position. No automated tests needed for a JS chart rendering fix.
No documentation changes needed.