Remove the UPX packing option and its build dependencies - #887
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup to #883, which stopped passing
--upxtoinstall_fs_pruned.sh. That left themachinery in place but unreachable. This removes it, so the option cannot be turned back on by
accident.
Context in #882: UPX self-extraction stubs are SIGKILLed at launch on hosts running CrowdStrike
Falcon, which surfaces as what looks like an out-of-memory failure.
What goes
tools/Docker/Dockerfile, thebuild_baseapt list:upx, andfilewith it.filewasonly ever there for the packing block, which located ELF binaries with
find "$fsd/bin" -exec file {} \; | grep ELF.aria2andca-certificatesstay, both used bythe downloader.
tools/build/install_fs_pruned.sh: the usage lines, theupx="false"default, the parsercase, the
upx=$upxcomponent of the cache stamp, and the packing block itself.Removed rather than left unused. The argument parser ends in
*) echo "Invalid argument $1" ; exit 1 ;;, so a stale caller passing--upxnow exits 1 withInvalid argument --upxinstead of being silently ignored, which is the right outcome forsomething that caused this class of failure.
The macOS build never passed
--upx(build_release_package.sh:156), so it is unaffected.Caches invalidate, on purpose
cache_stampincludes a sha256 of the script, so this commit invalidates every pruned-installcache: the Docker
build_freesurferstage and the macOS--fs-pruned-cache-dir. Both re-prunefrom scratch, which is what guarantees unpacked binaries. Each pays one full download and prune
the next time it runs.
This still does not fix the official images
Release builds copy FreeSurfer from the prebuilt
deepmi/fastsurfer-build:freesurfer741ratherthan compiling the stage, and that image is not a stamped cache, so no code change reaches it. It
has to be rebuilt and republished from the merged code:
The tag is derived from
tool.freesurfer.version, so it is overwritten in place and anyoneholding a cached copy needs to pull explicitly