Scope the workflow scan to the matrix block, so on: branches is not a dimension - #885
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the test reorganisation, left out of that PR by accident.
test_every_test_dir_runs.pysearched the whole workflow file forkey: [a, b]to find matrixdimensions, so
branches: [dev]underon:counted as one. It did not produce a false pass,because the intersection with the include keys was
{tests}either way, but a future includeentry keyed on something that also appears as a list elsewhere in the file would have slipped
through, and this file exists to catch exactly that class of silent gap.
Both scans are now scoped to their block through a shared
_block()helper, which also removesthe duplicated indentation walking.
Verified:
matrix dimensionsis now['pytest-flags', 'tests']rather than includingbranches. Re-checked against the two failure modes: deleting thetests:dimension still failstest_directory_is_run_by_ci[image]and the matrix-shape test, and a directory no workflow runsis still reported as uncovered. 98 tests pass, ruff clean.