Queue Improvements - #67
Open
ronfriedhaber wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cancel tokenfor async terminationNote
Low Risk
Localized queue client behavior changes with tests; cancellation is opt-in and does not alter default submit/poll semantics.
Overview
submit_and_pollnow copies the caller’s options dict before poppingon_status_change, so the original mapping is not mutated in place.Polling can be stopped cooperatively via an optional
cancel_token(asyncio.Event). A new_wait_or_cancelhelper replaces fixedasyncio.sleepduring the initial delay and between status checks; if the token is set, polling raisesasyncio.CancelledError(including before submit when the token is already set).on_status_changeis invoked only when the job status string actually changes, while still firing once for the initial post-submit status.Tests tighten the status-callback sequence expectations, assert the caller’s options dict is preserved, and add coverage for cancellation before submit.
Reviewed by Cursor Bugbot for commit 1aeb2d4. Bugbot is set up for automated code reviews on this repo. Configure here.