Skip to content

Avoid doing two separate http requests in stop telemetry - #2435

Open
bwoebi wants to merge 1 commit into
mainfrom
bob/consolidate-stop-telem
Open

Avoid doing two separate http requests in stop telemetry#2435
bwoebi wants to merge 1 commit into
mainfrom
bob/consolidate-stop-telem

Conversation

@bwoebi

@bwoebi bwoebi commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

This has not much impact in practice, but is observable, and obviously also races against each other, delivering payloads after app closing, which is not that problematic, but could be unexpected.

This has not much impact in practice, but is observable, and obviously also races against each other, delivering payloads after app closing, which is not that problematic, but could be unexpected.
@bwoebi
bwoebi requested a review from a team as a code owner August 28, 2026 17:41
@github-actions

Copy link
Copy Markdown
Contributor

📚 Documentation Check Results

⚠️ 570 documentation warning(s) found

📦 libdd-telemetry - 570 warning(s)


Updated: 2026-08-28 17:43:14 UTC | Commit: 7cd442d | missing-docs job results

@github-actions

Copy link
Copy Markdown
Contributor

🔒 Cargo Deny Results

⚠️ 3 issue(s) found, showing only errors (advisories, bans, sources)

📦 libdd-telemetry - 3 error(s)

Show output
error[vulnerability]: Invalid pointer dereference in `fmt::Pointer` impl for `Atomic` and `Shared` when the underlying pointer is invalid
   ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:53:1
   │
53 │ crossbeam-epoch 0.9.18 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
   │
   ├ ID: RUSTSEC-2026-0204
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0204
   ├ Affected versions of `fmt::Display` dereference the underlying pointer. This causes a invalid pointer dereference e.g., when a pointer created with `Atomic::null` or `Shared::null`. `fmt::Debug` impls and pre-0.9 `fmt::Display` impls, which do not dereference pointers, are not affected by this issue.
   ├ Announcement: https://github.com/crossbeam-rs/crossbeam/pull/1276
   ├ Solution: Upgrade to >=0.9.20 (try `cargo update -p crossbeam-epoch`)
   ├ crossbeam-epoch v0.9.18
     └── crossbeam-deque v0.8.5
         └── rayon-core v1.12.1
             └── rayon v1.10.0
                 └── criterion v0.5.1
                     └── (dev) libdd-ddsketch v1.1.1
                         └── libdd-telemetry v7.0.0

error[vulnerability]: h2 unbounded empty DATA frames
   ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:86:1
   │
86 │ h2 0.4.6 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
   │
   ├ ID: RUSTSEC-2026-0258
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0258
   ├ The h2 crate, used internally by hyper, had a flaw that would accept and queue empty DATA frames without limit.
     If streams were not actively drained, this could lead to unbounded memory usage, or a panic if the length overflows.
     
     Low severity.
     
     Patched in v0.4.16.
   ├ Announcement: https://github.com/hyperium/hyper/security/advisories/GHSA-q83h-524g-xf6h
   ├ Solution: Upgrade to >=0.4.16 (try `cargo update -p h2`)
   ├ h2 v0.4.6
     └── hyper v1.6.0
         ├── httpmock v0.8.0-alpha.1
         │   └── (dev) libdd-telemetry v7.0.0
         ├── hyper-rustls v0.27.7
         │   └── libdd-common v5.2.0
         │       ├── libdd-capabilities-impl v4.0.0
         │       │   ├── libdd-shared-runtime v3.0.0
         │       │   │   └── libdd-telemetry v7.0.0 (*)
         │       │   └── (dev) libdd-telemetry v7.0.0 (*)
         │       ├── libdd-shared-runtime v3.0.0 (*)
         │       └── libdd-telemetry v7.0.0 (*)
         ├── hyper-util v0.1.17
         │   ├── httpmock v0.8.0-alpha.1 (*)
         │   ├── hyper-rustls v0.27.7 (*)
         │   └── libdd-common v5.2.0 (*)
         └── libdd-common v5.2.0 (*)

error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:168:1
    │
168 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by [@lopopolo](https://github.com/lopopolo)) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── libdd-common v5.2.0
      │   ├── libdd-capabilities-impl v4.0.0
      │   │   ├── libdd-shared-runtime v3.0.0
      │   │   │   └── libdd-telemetry v7.0.0
      │   │   └── (dev) libdd-telemetry v7.0.0 (*)
      │   ├── libdd-shared-runtime v3.0.0 (*)
      │   └── libdd-telemetry v7.0.0 (*)
      ├── (dev) libdd-ddsketch v1.1.1
      │   └── libdd-telemetry v7.0.0 (*)
      └── proptest v1.5.0
          └── (dev) libdd-common v5.2.0 (*)

advisories FAILED, bans ok, sources ok

Updated: 2026-08-28 17:45:06 UTC | Commit: 7cd442d | dependency-check job results

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Aug 28, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 9 Pipeline jobs failed

Lint | clippy #ubuntu-latest msrv — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Compilation error in libdd-telemetry/src/worker/mod.rs:51:14: unused import: self.

Lint | clippy #ubuntu-latest nightly — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Compilation error in libdd-telemetry/src/worker/mod.rs:51:14: unused import: self.

Lint | clippy #ubuntu-latest stable — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Compilation error due to unused import in libdd-telemetry/src/worker/mod.rs:51:14

View all 9 failed jobs.

📋 Copy fix prompt
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:

1. Check whether you already have the Datadog software-delivery MCP tools
   (e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
   anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
   server and skills by following:
     https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
   then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.

Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.

If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.

Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:

1. Locate the change. Diff this branch against its base and find the change
   that produces this error. Explain the mechanism, don't just name a file:
     git fetch origin && git diff $(git merge-base origin/main HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
   proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
   not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
   so plainly instead of "fixing" it — that is a flaky test, and patching it
   hides the problem.

If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).

Branch: bob/consolidate-stop-telem

Lint | clippy #ubuntu-latest msrv
Commit: 7cd442d57dcc4940da3f724342fbad5ee1ca1ff0
Error (code / build):
Compilation error in libdd-telemetry/src/worker/mod.rs:51:14: unused import: `self`.
CI job: https://github.com/DataDog/libdatadog/actions/runs/33195858023/job/98933000387

Lint | clippy #ubuntu-latest nightly
Commit: 7cd442d57dcc4940da3f724342fbad5ee1ca1ff0
Error (code / build):
Compilation error in libdd-telemetry/src/worker/mod.rs:51:14: unused import: `self`.
CI job: https://github.com/DataDog/libdatadog/actions/runs/33195858023/job/98933000457

Lint | clippy #ubuntu-latest stable
Commit: 7cd442d57dcc4940da3f724342fbad5ee1ca1ff0
Error (code / build):
Compilation error due to unused import in libdd-telemetry/src/worker/mod.rs:51:14
CI job: https://github.com/DataDog/libdatadog/actions/runs/33195858023/job/98933000265

Plus 3 more failing jobs not shown here.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 80.00%
Overall Coverage: 76.67% (-0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 34a918e | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 28, 2026

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-08-28 17:49:48

Comparing candidate commit 34a918e in PR branch bob/consolidate-stop-telem with baseline commit 9fb27ea in branch ``.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 23 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:trace_buffer/4_senders/no_delay

  • 🟥 execution_time [+304.822µs; +335.427µs] or [+13.973%; +15.376%]
  • 🟥 throughput [-224870.734op/s; -202530.053op/s] or [-13.600%; -12.249%]

Benchmark execution time: 2026-08-28 17:47:45

Comparing candidate commit 34a918e in PR branch bob/consolidate-stop-telem with baseline commit 9fb27ea in branch ``.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 34a918e 1787938516 bob/consolidate-stop-telem
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.560ms 9.587ms ± 0.017ms 9.583ms ± 0.011ms 9.596ms 9.617ms 9.647ms 9.650ms 0.70% 1.152 1.745 0.17% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.584ms; 9.589ms] or [-0.024%; +0.024%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 34a918e 1787938516 bob/consolidate-stop-telem
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
trace_buffer/1_senders/10us_delay execution_time 56.408ms 56.704ms ± 0.160ms 56.673ms ± 0.086ms 56.799ms 57.058ms 57.198ms 57.216ms 0.96% 0.899 0.883 0.28% 0.011ms 1 200
trace_buffer/1_senders/10us_delay throughput 15729.810op/s 15871.892op/s ± 44.803op/s 15880.502op/s ± 24.111op/s 15900.243op/s 15936.462op/s 15944.023op/s 15955.103op/s 0.47% -0.882 0.843 0.28% 3.168op/s 1 200
trace_buffer/1_senders/1us_delay execution_time 50.001ms 50.085ms ± 0.039ms 50.081ms ± 0.014ms 50.092ms 50.157ms 50.202ms 50.222ms 0.28% 1.078 1.779 0.08% 0.003ms 1 200
trace_buffer/1_senders/1us_delay throughput 17920.607op/s 17969.633op/s ± 13.824op/s 17970.738op/s ± 4.952op/s 17976.132op/s 17989.184op/s 17991.673op/s 17999.529op/s 0.16% -1.072 1.764 0.08% 0.977op/s 1 200
trace_buffer/1_senders/no_delay execution_time 328.066µs 336.056µs ± 5.130µs 335.826µs ± 1.619µs 337.093µs 340.653µs 350.959µs 393.670µs 17.22% 7.389 78.522 1.52% 0.363µs 1 200
trace_buffer/1_senders/no_delay throughput 2286178.332op/s 2678682.538op/s ± 37043.793op/s 2679956.915op/s ± 12876.253op/s 2695557.055op/s 2716288.910op/s 2734627.249op/s 2743352.996op/s 2.37% -6.286 62.221 1.38% 2619.392op/s 1 200
trace_buffer/2_senders/10us_delay execution_time 57.136ms 57.488ms ± 0.102ms 57.494ms ± 0.064ms 57.555ms 57.635ms 57.700ms 57.740ms 0.43% -0.459 0.511 0.18% 0.007ms 1 200
trace_buffer/2_senders/10us_delay throughput 31174.000op/s 31311.192op/s ± 55.541op/s 31307.811op/s ± 34.646op/s 31344.724op/s 31408.279op/s 31468.288op/s 31503.806op/s 0.63% 0.471 0.531 0.18% 3.927op/s 1 200
trace_buffer/2_senders/1us_delay execution_time 50.025ms 50.110ms ± 0.032ms 50.105ms ± 0.019ms 50.126ms 50.173ms 50.202ms 50.228ms 0.24% 0.955 1.218 0.06% 0.002ms 1 200
trace_buffer/2_senders/1us_delay throughput 35836.940op/s 35920.720op/s ± 23.125op/s 35924.418op/s ± 13.453op/s 35936.648op/s 35949.208op/s 35957.242op/s 35981.864op/s 0.16% -0.951 1.209 0.06% 1.635op/s 1 200
trace_buffer/2_senders/no_delay execution_time 844.965µs 894.421µs ± 19.378µs 892.383µs ± 11.380µs 905.558µs 923.265µs 941.312µs 992.873µs 11.26% 1.130 4.815 2.16% 1.370µs 1 200
trace_buffer/2_senders/no_delay throughput 1812921.551op/s 2013394.697op/s ± 42734.712op/s 2017071.159op/s ± 25856.371op/s 2040876.798op/s 2070110.357op/s 2103586.706op/s 2130266.149op/s 5.61% -0.800 3.426 2.12% 3021.800op/s 1 200
trace_buffer/4_senders/10us_delay execution_time 57.327ms 57.566ms ± 0.107ms 57.557ms ± 0.055ms 57.607ms 57.727ms 57.927ms 58.287ms 1.27% 2.037 10.180 0.19% 0.008ms 1 200
trace_buffer/4_senders/10us_delay throughput 61762.981op/s 62537.224op/s ± 116.201op/s 62546.963op/s ± 60.190op/s 62612.114op/s 62689.668op/s 62726.749op/s 62797.320op/s 0.40% -1.993 9.842 0.19% 8.217op/s 1 200
trace_buffer/4_senders/1us_delay execution_time 50.107ms 50.168ms ± 0.036ms 50.160ms ± 0.016ms 50.182ms 50.249ms 50.272ms 50.313ms 0.30% 1.365 1.852 0.07% 0.003ms 1 200
trace_buffer/4_senders/1us_delay throughput 71552.405op/s 71758.309op/s ± 51.342op/s 71770.337op/s ± 23.392op/s 71792.202op/s 71817.470op/s 71834.607op/s 71846.645op/s 0.11% -1.361 1.838 0.07% 3.630op/s 1 200
trace_buffer/4_senders/no_delay execution_time 2.299ms 2.502ms ± 0.055ms 2.504ms ± 0.036ms 2.539ms 2.581ms 2.607ms 2.660ms 6.25% -0.418 0.505 2.19% 0.004ms 1 200
trace_buffer/4_senders/no_delay throughput 1353263.540op/s 1439765.647op/s ± 32005.103op/s 1437875.126op/s ± 20882.232op/s 1458825.565op/s 1497981.298op/s 1513611.686op/s 1565623.092op/s 8.88% 0.575 0.773 2.22% 2263.103op/s 1 200
trace_buffer/8_senders/10us_delay execution_time 57.695ms 58.020ms ± 0.262ms 57.911ms ± 0.118ms 58.203ms 58.517ms 58.668ms 58.765ms 1.47% 0.934 -0.347 0.45% 0.019ms 1 200
trace_buffer/8_senders/10us_delay throughput 122522.510op/s 124097.339op/s ± 557.685op/s 124327.996op/s ± 253.938op/s 124522.107op/s 124685.064op/s 124771.246op/s 124794.440op/s 0.38% -0.923 -0.371 0.45% 39.434op/s 1 200
trace_buffer/8_senders/1us_delay execution_time 50.207ms 50.298ms ± 0.065ms 50.275ms ± 0.032ms 50.327ms 50.425ms 50.524ms 50.534ms 0.51% 1.290 1.474 0.13% 0.005ms 1 200
trace_buffer/8_senders/1us_delay throughput 142477.765op/s 143148.278op/s ± 185.348op/s 143211.072op/s ± 91.844op/s 143277.558op/s 143349.675op/s 143375.744op/s 143406.204op/s 0.14% -1.283 1.448 0.13% 13.106op/s 1 200
trace_buffer/8_senders/no_delay execution_time 5.530ms 6.430ms ± 0.185ms 6.470ms ± 0.108ms 6.563ms 6.646ms 6.682ms 6.697ms 3.52% -1.412 2.929 2.87% 0.013ms 1 200
trace_buffer/8_senders/no_delay throughput 1075038.001op/s 1120699.527op/s ± 33694.019op/s 1112880.700op/s ± 18449.273op/s 1133557.752op/s 1186284.935op/s 1227843.662op/s 1302057.981op/s 17.00% 1.698 4.510 3.00% 2382.527op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
trace_buffer/1_senders/10us_delay execution_time [56.682ms; 56.727ms] or [-0.039%; +0.039%] None None None
trace_buffer/1_senders/10us_delay throughput [15865.683op/s; 15878.102op/s] or [-0.039%; +0.039%] None None None
trace_buffer/1_senders/1us_delay execution_time [50.079ms; 50.090ms] or [-0.011%; +0.011%] None None None
trace_buffer/1_senders/1us_delay throughput [17967.717op/s; 17971.549op/s] or [-0.011%; +0.011%] None None None
trace_buffer/1_senders/no_delay execution_time [335.345µs; 336.767µs] or [-0.212%; +0.212%] None None None
trace_buffer/1_senders/no_delay throughput [2673548.624op/s; 2683816.451op/s] or [-0.192%; +0.192%] None None None
trace_buffer/2_senders/10us_delay execution_time [57.473ms; 57.502ms] or [-0.025%; +0.025%] None None None
trace_buffer/2_senders/10us_delay throughput [31303.494op/s; 31318.889op/s] or [-0.025%; +0.025%] None None None
trace_buffer/2_senders/1us_delay execution_time [50.106ms; 50.115ms] or [-0.009%; +0.009%] None None None
trace_buffer/2_senders/1us_delay throughput [35917.515op/s; 35923.925op/s] or [-0.009%; +0.009%] None None None
trace_buffer/2_senders/no_delay execution_time [891.736µs; 897.107µs] or [-0.300%; +0.300%] None None None
trace_buffer/2_senders/no_delay throughput [2007472.077op/s; 2019317.317op/s] or [-0.294%; +0.294%] None None None
trace_buffer/4_senders/10us_delay execution_time [57.551ms; 57.581ms] or [-0.026%; +0.026%] None None None
trace_buffer/4_senders/10us_delay throughput [62521.120op/s; 62553.329op/s] or [-0.026%; +0.026%] None None None
trace_buffer/4_senders/1us_delay execution_time [50.163ms; 50.173ms] or [-0.010%; +0.010%] None None None
trace_buffer/4_senders/1us_delay throughput [71751.193op/s; 71765.424op/s] or [-0.010%; +0.010%] None None None
trace_buffer/4_senders/no_delay execution_time [2.494ms; 2.509ms] or [-0.305%; +0.305%] None None None
trace_buffer/4_senders/no_delay throughput [1435330.047op/s; 1444201.246op/s] or [-0.308%; +0.308%] None None None
trace_buffer/8_senders/10us_delay execution_time [57.984ms; 58.056ms] or [-0.063%; +0.063%] None None None
trace_buffer/8_senders/10us_delay throughput [124020.049op/s; 124174.629op/s] or [-0.062%; +0.062%] None None None
trace_buffer/8_senders/1us_delay execution_time [50.289ms; 50.307ms] or [-0.018%; +0.018%] None None None
trace_buffer/8_senders/1us_delay throughput [143122.591op/s; 143173.966op/s] or [-0.018%; +0.018%] None None None
trace_buffer/8_senders/no_delay execution_time [6.404ms; 6.456ms] or [-0.398%; +0.398%] None None None
trace_buffer/8_senders/no_delay throughput [1116029.860op/s; 1125369.194op/s] or [-0.417%; +0.417%] None None None

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 34a918e 1787938516 bob/consolidate-stop-telem
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 21.285µs 21.705µs ± 0.257µs 21.670µs ± 0.123µs 21.782µs 22.189µs 22.821µs 22.874µs 5.56% 1.736 4.849 1.18% 0.018µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [21.669µs; 21.740µs] or [-0.164%; +0.164%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 34a918e 1787938516 bob/consolidate-stop-telem
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 2.042µs 2.073µs ± 0.008µs 2.072µs ± 0.004µs 2.077µs 2.089µs 2.092µs 2.097µs 1.18% 0.219 0.956 0.40% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.072µs; 2.075µs] or [-0.056%; +0.056%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 34a918e 1787938516 bob/consolidate-stop-telem
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2644 execution_time 7.140ms 7.211ms ± 0.085ms 7.184ms ± 0.017ms 7.208ms 7.393ms 7.445ms 7.953ms 10.71% 4.239 28.041 1.18% 0.006ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2644 execution_time [7.200ms; 7.223ms] or [-0.164%; +0.164%] None None None

Baseline

Baseline benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9fb27ea 1787934813
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.559ms 9.586ms ± 0.018ms 9.580ms ± 0.009ms 9.595ms 9.616ms 9.650ms 9.688ms 1.12% 1.955 6.142 0.19% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.584ms; 9.589ms] or [-0.026%; +0.026%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9fb27ea 1787934813
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
trace_buffer/1_senders/10us_delay execution_time 56.390ms 56.732ms ± 0.188ms 56.711ms ± 0.107ms 56.819ms 57.099ms 57.265ms 57.398ms 1.21% 0.888 0.917 0.33% 0.013ms 1 200
trace_buffer/1_senders/10us_delay throughput 15679.974op/s 15864.101op/s ± 52.298op/s 15869.971op/s ± 29.883op/s 15899.831op/s 15935.813op/s 15958.485op/s 15960.329op/s 0.57% -0.867 0.868 0.33% 3.698op/s 1 200
trace_buffer/1_senders/1us_delay execution_time 49.926ms 50.086ms ± 0.037ms 50.083ms ± 0.012ms 50.094ms 50.159ms 50.195ms 50.197ms 0.23% 0.613 2.974 0.07% 0.003ms 1 200
trace_buffer/1_senders/1us_delay throughput 17929.257op/s 17969.051op/s ± 13.124op/s 17970.196op/s ± 4.330op/s 17974.593op/s 17988.553op/s 17991.427op/s 18026.737op/s 0.31% -0.603 2.984 0.07% 0.928op/s 1 200
trace_buffer/1_senders/no_delay execution_time 324.806µs 336.067µs ± 5.693µs 335.411µs ± 2.045µs 337.527µs 342.421µs 346.204µs 398.237µs 18.73% 6.679 69.493 1.69% 0.403µs 1 200
trace_buffer/1_senders/no_delay throughput 2259960.195op/s 2678726.789op/s ± 41178.990op/s 2683275.663op/s ± 16326.122op/s 2698949.229op/s 2722139.615op/s 2734726.602op/s 2770888.055op/s 3.27% -5.438 51.978 1.53% 2911.794op/s 1 200
trace_buffer/2_senders/10us_delay execution_time 57.085ms 57.410ms ± 0.128ms 57.417ms ± 0.088ms 57.498ms 57.611ms 57.694ms 57.766ms 0.61% 0.027 -0.426 0.22% 0.009ms 1 200
trace_buffer/2_senders/10us_delay throughput 31160.197op/s 31353.480op/s ± 69.688op/s 31349.373op/s ± 48.088op/s 31407.277op/s 31464.863op/s 31501.667op/s 31532.121op/s 0.58% -0.017 -0.430 0.22% 4.928op/s 1 200
trace_buffer/2_senders/1us_delay execution_time 50.043ms 50.116ms ± 0.036ms 50.111ms ± 0.017ms 50.127ms 50.189ms 50.228ms 50.246ms 0.27% 1.262 2.011 0.07% 0.003ms 1 200
trace_buffer/2_senders/1us_delay throughput 35823.415op/s 35916.827op/s ± 25.950op/s 35920.538op/s ± 11.968op/s 35932.639op/s 35948.742op/s 35956.261op/s 35969.087op/s 0.14% -1.257 1.997 0.07% 1.835op/s 1 200
trace_buffer/2_senders/no_delay execution_time 856.956µs 904.234µs ± 18.035µs 906.101µs ± 11.467µs 916.320µs 928.927µs 941.251µs 969.170µs 6.96% 0.020 0.380 1.99% 1.275µs 1 200
trace_buffer/2_senders/no_delay throughput 1857259.517op/s 1991423.554op/s ± 39757.700op/s 1986532.841op/s ± 25236.325op/s 2019327.243op/s 2059733.765op/s 2072944.248op/s 2100458.445op/s 5.73% 0.115 0.197 1.99% 2811.294op/s 1 200
trace_buffer/4_senders/10us_delay execution_time 57.435ms 57.641ms ± 0.136ms 57.605ms ± 0.059ms 57.681ms 57.934ms 58.056ms 58.079ms 0.82% 1.304 1.207 0.24% 0.010ms 1 200
trace_buffer/4_senders/10us_delay throughput 61984.518op/s 62455.813op/s ± 146.717op/s 62494.557op/s ± 64.368op/s 62548.938op/s 62623.430op/s 62666.921op/s 62679.633op/s 0.30% -1.293 1.177 0.23% 10.374op/s 1 200
trace_buffer/4_senders/1us_delay execution_time 50.124ms 50.169ms ± 0.037ms 50.157ms ± 0.015ms 50.181ms 50.244ms 50.285ms 50.366ms 0.42% 1.979 5.349 0.07% 0.003ms 1 200
trace_buffer/4_senders/1us_delay throughput 71477.121op/s 71757.496op/s ± 52.188op/s 71774.203op/s ± 21.034op/s 71788.457op/s 71809.667op/s 71819.357op/s 71822.127op/s 0.07% -1.972 5.301 0.07% 3.690op/s 1 200
trace_buffer/4_senders/no_delay execution_time 1.916ms 2.181ms ± 0.096ms 2.184ms ± 0.060ms 2.246ms 2.316ms 2.371ms 2.431ms 11.30% -0.311 -0.023 4.38% 0.007ms 1 200
trace_buffer/4_senders/no_delay throughput 1480709.898op/s 1653466.040op/s ± 73972.845op/s 1648037.738op/s ± 45285.083op/s 1693024.142op/s 1800116.802op/s 1840384.855op/s 1878442.834op/s 13.98% 0.560 0.201 4.46% 5230.670op/s 1 200
trace_buffer/8_senders/10us_delay execution_time 57.727ms 58.054ms ± 0.263ms 57.956ms ± 0.132ms 58.189ms 58.586ms 58.719ms 58.780ms 1.42% 1.036 0.013 0.45% 0.019ms 1 200
trace_buffer/8_senders/10us_delay throughput 122491.387op/s 124024.862op/s ± 558.557op/s 124231.725op/s ± 283.203op/s 124454.376op/s 124632.529op/s 124671.350op/s 124723.981op/s 0.40% -1.023 -0.016 0.45% 39.496op/s 1 200
trace_buffer/8_senders/1us_delay execution_time 50.218ms 50.290ms ± 0.056ms 50.271ms ± 0.028ms 50.315ms 50.412ms 50.468ms 50.484ms 0.42% 1.338 1.471 0.11% 0.004ms 1 200
trace_buffer/8_senders/1us_delay throughput 142618.221op/s 143170.744op/s ± 158.496op/s 143223.488op/s ± 80.630op/s 143281.463op/s 143344.626op/s 143363.630op/s 143374.843op/s 0.11% -1.332 1.451 0.11% 11.207op/s 1 200
trace_buffer/8_senders/no_delay execution_time 6.284ms 6.590ms ± 0.100ms 6.607ms ± 0.057ms 6.661ms 6.723ms 6.761ms 6.777ms 2.56% -0.830 0.446 1.52% 0.007ms 1 200
trace_buffer/8_senders/no_delay throughput 1062460.634op/s 1092828.472op/s ± 16874.642op/s 1089699.360op/s ± 9388.813op/s 1100392.204op/s 1128855.529op/s 1139932.745op/s 1145827.382op/s 5.15% 0.911 0.613 1.54% 1193.217op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
trace_buffer/1_senders/10us_delay execution_time [56.706ms; 56.758ms] or [-0.046%; +0.046%] None None None
trace_buffer/1_senders/10us_delay throughput [15856.853op/s; 15871.349op/s] or [-0.046%; +0.046%] None None None
trace_buffer/1_senders/1us_delay execution_time [50.081ms; 50.091ms] or [-0.010%; +0.010%] None None None
trace_buffer/1_senders/1us_delay throughput [17967.232op/s; 17970.869op/s] or [-0.010%; +0.010%] None None None
trace_buffer/1_senders/no_delay execution_time [335.278µs; 336.856µs] or [-0.235%; +0.235%] None None None
trace_buffer/1_senders/no_delay throughput [2673019.777op/s; 2684433.801op/s] or [-0.213%; +0.213%] None None None
trace_buffer/2_senders/10us_delay execution_time [57.392ms; 57.428ms] or [-0.031%; +0.031%] None None None
trace_buffer/2_senders/10us_delay throughput [31343.822op/s; 31363.139op/s] or [-0.031%; +0.031%] None None None
trace_buffer/2_senders/1us_delay execution_time [50.111ms; 50.121ms] or [-0.010%; +0.010%] None None None
trace_buffer/2_senders/1us_delay throughput [35913.230op/s; 35920.423op/s] or [-0.010%; +0.010%] None None None
trace_buffer/2_senders/no_delay execution_time [901.735µs; 906.734µs] or [-0.276%; +0.276%] None None None
trace_buffer/2_senders/no_delay throughput [1985913.519op/s; 1996933.589op/s] or [-0.277%; +0.277%] None None None
trace_buffer/4_senders/10us_delay execution_time [57.622ms; 57.660ms] or [-0.033%; +0.033%] None None None
trace_buffer/4_senders/10us_delay throughput [62435.480op/s; 62476.147op/s] or [-0.033%; +0.033%] None None None
trace_buffer/4_senders/1us_delay execution_time [50.164ms; 50.174ms] or [-0.010%; +0.010%] None None None
trace_buffer/4_senders/1us_delay throughput [71750.263op/s; 71764.729op/s] or [-0.010%; +0.010%] None None None
trace_buffer/4_senders/no_delay execution_time [2.168ms; 2.195ms] or [-0.608%; +0.608%] None None None
trace_buffer/4_senders/no_delay throughput [1643214.115op/s; 1663717.965op/s] or [-0.620%; +0.620%] None None None
trace_buffer/8_senders/10us_delay execution_time [58.018ms; 58.090ms] or [-0.063%; +0.063%] None None None
trace_buffer/8_senders/10us_delay throughput [123947.451op/s; 124102.272op/s] or [-0.062%; +0.062%] None None None
trace_buffer/8_senders/1us_delay execution_time [50.282ms; 50.297ms] or [-0.015%; +0.015%] None None None
trace_buffer/8_senders/1us_delay throughput [143148.778op/s; 143192.710op/s] or [-0.015%; +0.015%] None None None
trace_buffer/8_senders/no_delay execution_time [6.576ms; 6.604ms] or [-0.211%; +0.211%] None None None
trace_buffer/8_senders/no_delay throughput [1090489.809op/s; 1095167.136op/s] or [-0.214%; +0.214%] None None None

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 9fb27ea 1787934813
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 21.051µs 21.650µs ± 0.314µs 21.592µs ± 0.123µs 21.743µs 22.221µs 22.575µs 23.870µs 10.55% 3.499 19.620 1.45% 0.022µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [21.606µs; 21.693µs] or [-0.201%; +0.201%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 9fb27ea 1787934813
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 2.055µs 2.075µs ± 0.009µs 2.074µs ± 0.005µs 2.080µs 2.091µs 2.093µs 2.094µs 0.97% 0.431 -0.370 0.41% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.074µs; 2.076µs] or [-0.058%; +0.058%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 9fb27ea 1787934813
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2644 execution_time 7.104ms 7.189ms ± 0.068ms 7.162ms ± 0.018ms 7.199ms 7.343ms 7.414ms 7.440ms 3.89% 1.806 2.539 0.95% 0.005ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2644 execution_time [7.180ms; 7.199ms] or [-0.132%; +0.132%] None None None

@dd-octo-sts

dd-octo-sts Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 89.74 MB 89.46 MB --.32% (-295.03 KB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.26 MB 8.20 MB --.75% (-64.00 KB) 💪
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.13 MB 11.06 MB --.66% (-75.83 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 100.97 MB 100.67 MB --.29% (-305.65 KB) 💪
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 26.68 MB 26.55 MB --.47% (-131.00 KB) 💪
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 94.96 KB 94.96 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 181.16 MB 179.98 MB --.65% (-1.18 MB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 770.91 MB 763.56 MB --.95% (-7.35 MB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.75 MB 8.72 MB --.32% (-29.00 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 94.96 KB 94.96 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 25.70 MB 25.61 MB --.36% (-96.00 KB) 💪
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.17 MB 51.00 MB --.32% (-171.06 KB) 💪
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.25 MB 23.13 MB --.50% (-121.00 KB) 💪
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 96.45 KB 96.45 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 186.11 MB 184.90 MB --.65% (-1.21 MB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 756.49 MB 750.97 MB --.72% (-5.51 MB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.76 MB 6.73 MB --.41% (-28.50 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 96.45 KB 96.45 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 27.64 MB 27.54 MB --.36% (-104.00 KB) 💪
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 48.71 MB 48.55 MB --.33% (-165.07 KB) 💪
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 80.03 MB 79.76 MB --.33% (-277.67 KB) 💪
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.18 MB 9.15 MB --.29% (-28.00 KB) 💪
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.76 MB 95.48 MB --.28% (-280.93 KB) 💪
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.20 MB 11.17 MB --.25% (-29.72 KB) 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant