Fix converter output display - #878
Open
Creylay wants to merge 2 commits into
Open
Conversation
Creylay
added this pull request to stack #879
September 11, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related fixes to the session preprocessing wizard: two converter steps of the same type used to render with an identical name (e.g. two "Simple Imputer" cards), which made them hard to tell apart, and when scoping a new converter over an earlier step's output group, the picker showed the raw internal key (e.g.
__group__0) instead of a readable label.Type of Change
Check all that apply like this [x]:
Changes (by file)
sessionColumnRefs.js: addedbuildStepDisplayNames, which numbers steps that share a converter type by order of appearance (e.g. "Simple Imputer", "Simple Imputer (2)"), and threaded an optionalconvertersMetathroughbuildColumnKeysAndTypesso its option labels use these disambiguated names.AppliedConvertersView.jsx: replaced its own local name-resolution logic with the sharedbuildStepDisplayNames, and dropped the redundant "(slot)" text from an output group's label now that its type is already shown as a colored chip next toSelectColumnsStep.jsx: now fetches converter metadata and passes it intobuildColumnKeysAndTypes, so the final column-selection step shows the same disambiguated names as the rest of the wizard.ColumnSelector.jsx(shared with Notebooks): added an optionaloptionLabelsprop. A row whose key has a label (a converter's output group) now renders as a chip with itsname and a colored type badge, matching the same chip style used elsewhere.l renders as plain text, unchanged.
ScopeStepSessionConverter.jsx: now passes the resolvedoptionLabels(previously discarded) intoColumnSelector, fixing the raw__group__0key showing up when scoping anew converter over an earlier step's output.
FormSessionConverterSection.jsx,SessionConvertersRightBar.jsx: threadedconvertersMeta(already fetched in the right bar for the converter list) down toScopeStepSessionConverter, so its labels match the disambiguated names ussessionColumnRefs.test.js,AppliedConvertersView.test.jsx: added coverage for the numbering behavior and the removal of the redundant slot text.Testing (optional)
__group__0key.