Fix const CRect& argument deduction in CMenuManager::DrawWindow - #330
Open
Akionka wants to merge 1 commit into
Open
Fix const CRect& argument deduction in CMenuManager::DrawWindow#330Akionka wants to merge 1 commit into
Akionka wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an incorrect argument type deduction in
CMenuManager::DrawWindow.plugin::CallMethodtakes its argument pack asArgs... args, so when the argument types are not specified explicitly, the reference and top-levelconstonconst CRect&are stripped during template argument deduction.As a result, the current code deduces
CRectby value instead ofconst CRect&, producing an incorrect function signature/ABI for the call to0x573EE0.Verification
The original
gta_sa.execonfirms that0x573EE0expects the first argument as a single pointer/reference-sized stack argument.Native call sites construct a
CRect, take its address, and pass that address as the first argument:The same pattern appears at several other call sites:
Inside
0x573EE0, the first argument is loaded intoESIand then used as a pointer to accessCRectfields:The function also ends with:
which confirms that it expects six 4-byte stack arguments.
Without explicitly specifying
const CRect&,CallMethoddeduces the argument pack as approximately:instead of:
which results in an incompatible call ABI.