Fix CMenuManager::DrawQuitGameScreen signature - #328
Open
Akionka wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the incorrect
int unusedparameter fromCMenuManager::DrawQuitGameScreen.The function at
0x57D860in GTA SA 1.0 US uses ECX as this and ends with a plain:retrather than:
For an
x86 __thiscallfunction, a single explicit 32-bit argument would be passed on the stack and cleaned up by the callee withret 4, even if the argument itself was unused.Therefore the function appears to have no explicit parameters.
Changed from:
to:
This also avoids the stack/calling-convention mismatch caused by passing an argument to a function that does not clean it up.