Conformance test suite + CI + malformed-point decode vectors (fixes #85) - #86
Open
liqdmetal wants to merge 1 commit into
Open
Conformance test suite + CI + malformed-point decode vectors (fixes #85)#86liqdmetal wants to merge 1 commit into
liqdmetal wants to merge 1 commit into
Conversation
Author
liqdmetal
force-pushed
the
feature/conformance-suite
branch
from
August 23, 2026 03:26
e2a8e23 to
87259eb
Compare
…(no vendor noise) Reproducible correctness oracle: bn256/bulletproof test vectors + the malformed-point (x>=p) decode vector + a GitHub Actions build/test gate. Upstream has zero CI today; this is the first.
liqdmetal
force-pushed
the
feature/conformance-suite
branch
from
August 25, 2026 01:22
6abadd1 to
2088b13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Executable conformance suite for the DERO transaction relation + CI + malformed-point decode vectors. Tests-only (no consensus change, no production code touched).
What's in it
TestConformance_ValidProofTestConformance_MutationsRejectedTestConformance_RingSizeMatrixTestG2P0_SameIndexAttackTestG2P0_FakeReceiverMutationTestK0_RingSize2IsIdentifiableTestConformance_DeterminismTestConformance_MalformedPointDecodeThe malformed-point vectors (why they matter)
A Rust differential harness (clean-room reimplementation, differentially tested against this codebase) found that
bn256/changes.godiscards the on-curve error whenx >= p— Go "succeeds" with an invalid point while a strict decoder rejects. This is a chain-split class bug if a contract ever stores a malformed point (commitments, point-arithmetic outputs). The vectors pin both implementations: the assertion is determinism-only (no panic, same result per call) so Go and a strict Rust decoder can converge on the exact accept/reject rule.Confirmed live by the vectors:
x_gt_pandbad_flaginputs currently decode witherr = nilin Go.CI
.github/workflows/build-and-test.yml— builds the tree + runs the conformance, DVM-intrinsic, and K0 suites on Go 1.25. The tree needs-mod=mod(the releasedvendor/is incomplete — novendor/modules.txt); go.mod pins the jrpc2/readline versions that actually provide the APIs the code uses.Relationship to the other PRs
This is the "Submission C" conformance piece from the K0/DVM program. It strengthens the whole set:
Branch:
feature/conformance-suitein the forkliqdmetal/derohe-improvements-by-liqdmetal. Flat oncommunity-dev.