Migrate guides from FCP Development guide - #139
Conversation
# Conflicts: # mkdocs.yml
|
|
||
| When done ensure you delete the branch. Again GitHub will present this option in the UI immediately after merging so make use of it then. | ||
|
|
||
| ## Reviewing a pull request |
There was a problem hiding this comment.
Worth merging this content with the "Get it looked at" section above? At the moment we have two sections talking about reviews
I'd also like to see "Get it looked at" changed to "Get it reviewed" or something, I don't really like the chatty language!
| At least one reviewer must approve a pull request before it can be merged. | ||
|
|
||
| ### Tone of code review comments | ||
|
|
There was a problem hiding this comment.
I think it's useful to have the above bit of text about having at least one review merged into the "Get it looked at" section. But the rest of the sections about how and when to review could go stay at the end in a "Tips for reviewing PRs" section.
My only concern is that if it all went into the "Get it looked at" section, it's a bit long and the "Completing the PR" will get lost. So having all the below text at the end as tips might work well? (People can ready if they feel they need the additional guidance)?
2 participants
No description provided.