Report the crafting state when the furnace crafting game tests time out - #236
Merged
rubensworks merged 1 commit intoSep 12, 2026
Merged
Conversation
testItemsCraftIngotsAndExtractFromStorage failed sporadically with one raw iron left in the input chest, and the message only said which item was left, which is not enough to tell a slow craft from a stuck one. Both furnace tests now also report the crafting jobs of their interface with their status, ingredient buffer and running operations, the interface's result buffer, and the contents of the furnace. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CYLrSSsEJgQocz2Z4BSFfU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testItemsCraftIngotsAndExtractFromStoragefailed sporadically with:The message says what did not happen, but nothing about why, so a sporadic failure like this leaves nothing to work with. Both furnace tests now also report the crafting jobs of their interface (status, ingredient buffer, number of running operations), the interface's result buffer, and the contents of the furnace:
That separates the possible causes at a glance:
missing-ingredients: its ingredient buffer was never (re)filledWhy only diagnostics
I could not reproduce the failure here: running the scenario ~600 times (40 concurrent copies of the test per game test server run) gave no failure at all. Instrumenting those copies to log the tick at which they succeed shows that the test finishes between 1508 and 1908 ticks, with a median of 1608, out of the 4000 ticks it is given. The reported failure is therefore not a test that was merely slow: with one raw iron left, the crafting pipeline stopped making progress for over 2000 ticks somewhere around the 7th of its 8 smelting operations. Raising the timeout would not have helped, so this PR does not touch it, and instead makes the next occurrence say where it got stuck.
For reference:
master-1.21,master-26andmaster-26-ltsgive these two testsTIMEOUT * 5instead ofTIMEOUT * 2, which dates back to the merge in f15673c and was never brought back tomaster-1.21-lts. Happy to align that here too if you want the branches consistent.🤖 Generated with Claude Code
https://claude.ai/code/session_01CYLrSSsEJgQocz2Z4BSFfU
Generated by Claude Code