-
Notifications
You must be signed in to change notification settings - Fork 18
ci(release-ctx): build ctx from a build ref, attach to the release tag #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
echobt
wants to merge
10
commits into
main
Choose a base branch
from
cursor/release-ctx-build-ref-db7b
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
84b0d9d
ci(release-ctx): build ctx from a build ref, attach to the release tag
cursoragent 535c095
fix(install-ctx): name the release that has no ctx assets
cursoragent c4abab1
docs(release): ctx release recipe and CTX_VERSION pin
cursoragent 4391ef0
ci(release-ctx): release only commits on main, drop the cargo cache
cursoragent 43d0b62
docs(release): ctx is built from commits on main only, no cache
cursoragent a752be6
ci(release-ctx): dispatch builds the tip of main, no build_ref input
cursoragent 9c87db9
docs(release): dispatch builds main tip; tag an older commit instead
cursoragent af7b270
ci(release-ctx): name the resolved commit revision, not sha
cursoragent e9050ee
ci(release-ctx): pin every action by sha, fail closed on notes lookup
cursoragent 9734de9
fix(install-ctx): only a 404 means the release is absent
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A failed release-body lookup is unconditionally converted into an empty body. A temporary API, authentication, or network failure therefore makes the marker check generate a new installation block; with
append_body: true, an existing release receives a duplicate block. This is non-blocking, but it leaves public release notes confusing and no longer limited to one installation section.Artifacts
Evidence from the check
Command output from the check
Command output from the check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e9050ee: the lookup no longer swallows errors. Only a
gh release viewfailure whose stderr saysrelease not foundis treated as "no Release yet" (the next step creates it); any other exit (API 5xx, auth, network) fails the step with::error::could not read the release notes … refusing to guessand prints gh's stderr, so a transient failure can never append a duplicate block. Simulated with a gh stub returningHTTP 503→ step exits 1, no body emitted.