Skip to content

build(deps): bump mdns-sd from 0.11.5 to 0.21.3 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build(deps): bump mdns-sd from 0.11.5 to 0.21.3 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 41 additions & 33 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ chardetng = "0.1"
sha1 = "0.10"

# CLI - mDNS / Service Discovery
mdns-sd = "0.11"
mdns-sd = "0.21"

@greptile-apps greptile-apps Bot Sep 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Restore mDNS compatibility

Updating mdns-sd to 0.21.3 leaves cortex-engine using the older mDNS API. Resolved events now contain Box<ResolvedService> rather than the ServiceInfo accepted by the existing converter, and the returned timeout error comes from flume 0.12 while the caller matches the direct flume 0.11 type. Consequently, cortex-app-server fails to compile with six type errors. Update the resolved-service handling and align the channel error type before merging.

Artifacts

Evidence from the check

  • The read-only script creates a detached pre-upgrade worktree, runs the matching narrow Cargo checks, and captures the dependency diff and mDNS call sites; it is the complete executed source.

Command output from the check

  • The matching Cargo check was run against HEAD^ and stopped during offline dependency resolution because the local cache lacks polling required by mdns-sd 0.11.5; the before build result cannot be established offline.

Command output from the check

  • The locked offline Cargo check was run against the upgraded revision and reports six E0308 errors in cortex-engine for ServiceResolved and flume timeout-error incompatibilities; the upgrade breaks the build.

Command output from the check

  • The captured command output shows mdns-sd changing from 0.11.5 to 0.21.3, flume 0.12.0 entering the lockfile, and the exact cortex-engine and cortex-app-server ServiceResolved call sites; the incompatibilities map directly to current source.

View artifacts

T-Rex Ran code and verified through T-Rex

hostname = "0.4"

# CLI - PTY
Expand Down
Loading