Skip to content

Check service exclude - #458

Merged
lgmu merged 4 commits into
ConSol-Monitoring:mainfrom
lgmu:check-service-exclude
Aug 31, 2026
Merged

Check service exclude#458
lgmu merged 4 commits into
ConSol-Monitoring:mainfrom
lgmu:check-service-exclude

Conversation

@lgmu

@lgmu lgmu commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Extends check_service exclude parameter with wildcards, kept case-insensitive matching

e.g. check_service "exclude=Google*"

@lgmu

lgmu commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

exclude arg also exists in other checks but it doesn't really make sense to add the wildcard option there imo:

check_omd -> there are not that many services by default and usually shouldn't be excluded anyway
check_network -> currently case sensitive, I think here we could implement it, but then we should also make it case insensitive
check_drivesize -> for windows it doesn't make sense, for linux it could make sense in certain cases, but it's more complex because it currently already does stuff with trailing slashes or backslashes

@sni

sni commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

the only thing that bothers me, is that this PR add the exact same test twice.

@lgmu
lgmu requested a review from sni August 31, 2026 13:16
@lgmu
lgmu merged commit f18efca into ConSol-Monitoring:main Aug 31, 2026
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants