Skip to content

[T3412] FIX: Correctly set contract lines on W&P sponsorship contracts - #2157

Merged
ecino merged 1 commit into
18.0from
T3412-fix-wp-sponsorship
Sep 17, 2026
Merged

ecino merged 1 commit into
18.0from
T3412-fix-wp-sponsorship

Conversation

@AlexandrePhilibert

@AlexandrePhilibert AlexandrePhilibert commented Sep 15, 2026

Copy link
Copy Markdown

This fixes the W&P sponsorships amount being set when a new one is created.

Linked to CompassionCH/compassion-switzerland#1824

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

Safe to merge: the exercised type-precedence cases produce the intended correspondence and standard sponsorship line behavior.

What we checked:

  • We compared the payment-group onchange behavior for SC, SWP, and standard sponsorship contracts before and after the change. T-Rex
  • We observed that the updated logic rebuilds SC and SWP lines with amount 0 and standard sponsorship lines with amount 42, regardless of stale or absent default-type context. T-Rex
  • We noted that the closest existing SWP consistency test covers consistency repair rather than the group_id onchange precedence path. T-Rex
  • We attempted a full Odoo test, but it could not start because odoo-bin was unavailable. T-Rex

Reviews (1) · Last reviewed commit: "[T3412] FIX: Correctly set contract line..."

@ecino
ecino merged commit 8ca3305 into 18.0 Sep 17, 2026
2 checks passed
@ecino
ecino deleted the T3412-fix-wp-sponsorship branch September 17, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants