fix: force utf-8 encoding on all text file reads/writes - #278
Merged
Conversation
Several read_text()/open() calls relied on the platform's default encoding (locale-dependent), which breaks on ASCII-locale systems (e.g. bioconda's Linux test env, UnicodeDecodeError on texts.toml) and mis-encodes on non-UTF-8 Windows locales (e.g. French cp1252).
paretje
reviewed
Aug 5, 2026
|
|
||
| # Write full configuration including defaults to file | ||
| with open(output_file_root + ".full-config.json", "w") as f: | ||
| with open(output_file_root + ".full-config.json", "w", encoding="utf-8") as f: |
Contributor
There was a problem hiding this comment.
Would it make sense to do this for the other output files as well?
Member
Author
There was a problem hiding this comment.
I guess it would for consistency. Would it make sense from an end-user perspective?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several read_text()/open() calls relied on the platform's default encoding (locale-dependent), which breaks on ASCII-locale systems (e.g. bioconda's Linux test env, UnicodeDecodeError on texts.toml) and mis-encodes on non-UTF-8 Windows locales (e.g. French cp1252).